Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared links to folders no longer allow viewing full-size images #21446

Closed
plaes opened this issue Jun 17, 2020 · 3 comments
Closed

Shared links to folders no longer allow viewing full-size images #21446

plaes opened this issue Jun 17, 2020 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@plaes
Copy link

plaes commented Jun 17, 2020

After upgrade to 18.0.6, shared links do not allow viewing images when clicking on them.
("Download all files" button works though..)

Steps to reproduce

  1. Open any previously shared link (or create a new shared link yourself) and visit it anonymously.
  2. Make sure that shared folder view is opened up
  3. Click on the image to view it

Expected behaviour

Image should show

Actual behaviour

Loading icon is showing and there's a 401 error message in the console:

<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\NotAuthenticated</s:exception>
  <s:message/>
</d:error>

Server configuration

Operating system: Debian Linux

Web server: nginx

Database: sqlite3 v3.27.2

PHP version: Versioon: 7.3.11

Nextcloud version: 18.0.6

Updated from an older Nextcloud/ownCloud or fresh install: Upgraded from 18.0.4

Where did you install Nextcloud from: Official way (?)

Signing status:

Signing status
No errors have been found.

List of activated apps:

App list
Enabled:
  - accessibility: 1.4.0
  - activity: 2.11.0
  - bruteforcesettings: 1.6.0
  - calendar: 2.0.3
  - camerarawpreviews: 0.7.4
  - cloud_federation_api: 1.1.0
  - comments: 1.8.0
  - dav: 1.14.0
  - deck: 1.0.2
  - federatedfilesharing: 1.8.0
  - federation: 1.8.0
  - files: 1.13.1
  - files_pdfviewer: 1.7.0
  - files_rightclick: 0.15.2
  - files_sharing: 1.10.1
  - files_trashbin: 1.8.0
  - files_versions: 1.11.0
  - files_videoplayer: 1.7.0
  - firstrunwizard: 2.7.0
  - logreader: 2.3.0
  - lookup_server_connector: 1.6.0
  - mail: 1.4.0
  - metadata: 0.11.1
  - nextcloud_announcements: 1.7.0
  - notes: 3.5.1
  - notifications: 2.6.0
  - oauth2: 1.6.0
  - password_policy: 1.8.0
  - photos: 1.0.0
  - previewgenerator: 2.3.0
  - privacy: 1.2.0
  - provisioning_api: 1.8.0
  - recommendations: 0.6.0
  - serverinfo: 1.8.0
  - settings: 1.0.0
  - sharebymail: 1.8.0
  - support: 1.1.1
  - survey_client: 1.6.0
  - systemtags: 1.8.0
  - text: 2.0.0
  - theming: 1.9.0
  - twofactor_backupcodes: 1.7.0
  - updatenotification: 1.8.0
  - viewer: 1.2.0
  - workflowengine: 2.0.0
Disabled:
  - admin_audit
  - encryption
  - files_external
  - issuetemplate
  - spreed
  - twofactor_u2f
  - user_ldap

Nextcloud configuration:

Config report
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "sipsik.plaes.org",
            "qnap.local"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "***REMOVED VALUE***"",
        "dbtype": "sqlite3",
        "version": "18.0.6.0",
        "installed": true,
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "updater.release.channel": "stable",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0
        },
        "enabledPreviewProviders": [
            "OC\\Preview\\Image",
            "OC\\Preview\\Movie"
        ]
    }
}

Are you using external storage, if yes which one: no
Are you using encryption: no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Client configuration

**Browser:**Any

Operating system: Any

Logs

Web server error log

Web server error log
Insert your webserver log here

Nextcloud log (data/nextcloud.log)

Nextcloud log
Nothing relevant regarding this there...

Browser log

Browser log
Insert your browser log here, this could for example include:

Javascript console log:

QMIGRATE: Migrate is installed, version 1.4.1
2main.js?v=a1031e3c-4:1082 Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20
ne @ main.js?v=a1031e3c-4:1082
/ocs/v2.php/apps/text/public/workspace?path=%2F&shareToken=Hcatd64owtwBQ4d:1 Failed to load resource: the server responded with a status of 404 (Not Found)
57main.js?v=a1031e3c-4:1082 The humanFileSize library is deprecated! It will be removed in nextcloud 19.
ne @ main.js?v=a1031e3c-4:1082
viewer.js?v=a1031e3c-4:369 Opening the viewer with a single string parameter is deprecated. Please use a destructuring object instead OCA.Viewer.open({ path: '/IMG_20191107_101430.jpg' })
value @ viewer.js?v=a1031e3c-4:369
viewer.js?v=a1031e3c-4:347 Opening viewer for file  /IMG_20191107_101430.jpg
/public.php/webdav/IMG_20191107_101430.jpg:1 Failed to load resource: the server responded with a status of 401 (Unauthorized)
viewer.js?v=a1031e3c-4:347 Error: Request failed with status code 401
    at t.exports (viewer.js?v=a1031e3c-4:39)
    at t.exports (viewer.js?v=a1031e3c-4:260)
    at XMLHttpRequest.h.onreadystatechange (viewer.js?v=a1031e3c-4:39)
(anonymous) @ viewer.js?v=a1031e3c-4:347
DevTools failed to load SourceMap: Could not parse content for https://sipsik.plaes.org/core/js/dist/main.js.map: Unexpected token < in JSON at position 0
DevTools failed to load SourceMap: Could not parse content for https://sipsik.plaes.org/apps/files_videoplayer/js/main.js.map: Unexpected token < in JSON at position 0
DevTools failed to load SourceMap: Could not parse content for https://sipsik.plaes.org/apps/files_sharing/js/dist/main.js.map: Unexpected token < in JSON at position 0
DevTools failed to load SourceMap: Could not parse content for https://sipsik.plaes.org/apps/viewer/js/viewer.js.map: Unexpected token < in JSON at position 0
DevTools failed to load SourceMap: Could not parse content for https://sipsik.plaes.org/apps/text/js/public.js.map: Unexpected token < in JSON at position 0
DevTools failed to load SourceMap: Could not parse content for https://sipsik.plaes.org/apps/text/js/vendor.js.map?v=f6ab5562fe05f8500a71: Unexpected token < in JSON at position 0
viewer.js?v=a1031e3c-4:369 Opening the viewer with a single string parameter is deprecated. Please use a destructuring object instead OCA.Viewer.open({ path: '/IMG_20191107_101430.jpg' })
value @ viewer.js?v=a1031e3c-4:369
actionHandler @ viewer.js?v=a1031e3c-4:347
action @ fileactions.js?v=a1031e3c-4:136
_onClickFile @ filelist.js?v=a1031e3c-4:901
I @ main.js?v=a1031e3c-4:25
(anonymous) @ main.js?v=a1031e3c-4:25
(anonymous) @ main.js?v=a1031e3c-4:25
dispatch @ main.js?v=a1031e3c-4:25
v.handle @ main.js?v=a1031e3c-4:25
viewer.js?v=a1031e3c-4:347 Opening viewer for file  /IMG_20191107_101430.jpg
viewer.js?v=a1031e3c-4:39 PROPFIND https://sipsik.plaes.org/public.php/webdav/IMG_20191107_101430.jpg 401 (Unauthorized)
(anonymous) @ viewer.js?v=a1031e3c-4:39
t.exports @ viewer.js?v=a1031e3c-4:39
t.exports @ viewer.js?v=a1031e3c-4:260
Promise.then (async)
c.request @ viewer.js?v=a1031e3c-4:260
(anonymous) @ viewer.js?v=a1031e3c-4:39
(anonymous) @ viewer.js?v=a1031e3c-4:260
value @ viewer.js?v=a1031e3c-4:260
value @ viewer.js?v=a1031e3c-4:260
c @ viewer.js?v=a1031e3c-4:260
t.exports @ viewer.js?v=a1031e3c-4:260
request @ viewer.js?v=a1031e3c-4:14
getStat @ viewer.js?v=a1031e3c-4:261
stat @ viewer.js?v=a1031e3c-4:260
(anonymous) @ viewer.js?v=a1031e3c-4:324
u @ main.js?v=a1031e3c-4:565
(anonymous) @ main.js?v=a1031e3c-4:565
forEach.e.<computed> @ main.js?v=a1031e3c-4:565
F @ viewer.js?v=a1031e3c-4:303
s @ viewer.js?v=a1031e3c-4:303
(anonymous) @ viewer.js?v=a1031e3c-4:303
(anonymous) @ viewer.js?v=a1031e3c-4:303
z @ viewer.js?v=a1031e3c-4:324
(anonymous) @ viewer.js?v=a1031e3c-4:347
u @ main.js?v=a1031e3c-4:565
(anonymous) @ main.js?v=a1031e3c-4:565
forEach.e.<computed> @ main.js?v=a1031e3c-4:565
G @ viewer.js?v=a1031e3c-4:324
s @ viewer.js?v=a1031e3c-4:347
(anonymous) @ viewer.js?v=a1031e3c-4:347
(anonymous) @ viewer.js?v=a1031e3c-4:347
(anonymous) @ viewer.js?v=a1031e3c-4:347
(anonymous) @ viewer.js?v=a1031e3c-4:347
u @ main.js?v=a1031e3c-4:565
(anonymous) @ main.js?v=a1031e3c-4:565
forEach.e.<computed> @ main.js?v=a1031e3c-4:565
Q @ viewer.js?v=a1031e3c-4:347
s @ viewer.js?v=a1031e3c-4:347
(anonymous) @ viewer.js?v=a1031e3c-4:347
(anonymous) @ viewer.js?v=a1031e3c-4:347
openFile @ viewer.js?v=a1031e3c-4:347
file @ viewer.js?v=a1031e3c-4:347
pn.run @ viewer.js?v=a1031e3c-4:14
ln @ viewer.js?v=a1031e3c-4:14
(anonymous) @ viewer.js?v=a1031e3c-4:14
Xt @ viewer.js?v=a1031e3c-4:14
Promise.then (async)
Vt @ viewer.js?v=a1031e3c-4:14
ee @ viewer.js?v=a1031e3c-4:14
(anonymous) @ viewer.js?v=a1031e3c-4:14
pn.update @ viewer.js?v=a1031e3c-4:14
lt.notify @ viewer.js?v=a1031e3c-4:14
set @ viewer.js?v=a1031e3c-4:14
value @ viewer.js?v=a1031e3c-4:369
actionHandler @ viewer.js?v=a1031e3c-4:347
action @ fileactions.js?v=a1031e3c-4:136
_onClickFile @ filelist.js?v=a1031e3c-4:901
I @ main.js?v=a1031e3c-4:25
(anonymous) @ main.js?v=a1031e3c-4:25
(anonymous) @ main.js?v=a1031e3c-4:25
dispatch @ main.js?v=a1031e3c-4:25
v.handle @ main.js?v=a1031e3c-4:25
Show 15 more frames
viewer.js?v=a1031e3c-4:347 Error: Request failed with status code 401
    at t.exports (viewer.js?v=a1031e3c-4:39)
    at t.exports (viewer.js?v=a1031e3c-4:260)
    at XMLHttpRequest.h.onreadystatechange (viewer.js?v=a1031e3c-4:39)

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
@plaes plaes added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jun 17, 2020
@SimplyCorbett
Copy link

Issue happens on NC19 as well. Constant loading circle when trying to open an image in a shared folder.

firefox_2SVnc1MMCk

@szaimen
Copy link
Contributor

szaimen commented Jun 17, 2020

Does this help?
nextcloud/viewer#500 (comment)

@plaes
Copy link
Author

plaes commented Jun 17, 2020

Does this help?
nextcloud/viewer#500 (comment)

Yup, this helps.

Duplicate of #20132 (comment)

@plaes plaes closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

No branches or pull requests

3 participants