Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dark themed color picker and use button component #3411

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix dark themed color picker and use button component #3411

merged 1 commit into from
Nov 2, 2022

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 31, 2022

Before After
image image
image image

@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: colorpicker Related to the colorpicker component labels Oct 31, 2022
@Pytal Pytal added this to the 7.0.2 milestone Oct 31, 2022
@Pytal Pytal self-assigned this Oct 31, 2022
nickvergessen
nickvergessen approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but looks good

@Pytal
Copy link
Contributor Author

Pytal commented Nov 2, 2022

/rebase

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2022
@Pytal
Fix dark themed color picker and use button component
9082478 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@nextcloud-command nextcloud-command force-pushed the fix/color-picker-dark-background branch from e5f518a to 9082478 Compare November 2, 2022 23:08
@Pytal Pytal merged commit 6d27a14 into master Nov 2, 2022
@Pytal Pytal deleted the fix/color-picker-dark-background branch November 2, 2022 23:23
@skjnldsv skjnldsv mentioned this pull request Nov 15, 2022
Merged
@skjnldsv skjnldsv modified the milestones: 7.0.2, 7.1.0 Nov 16, 2022
@nickvergessen
Copy link
Contributor

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge artonge approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: colorpicker Related to the colorpicker component
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @nickvergessen @artonge @skjnldsv