-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to render x items outside an Actions menu #3060
Conversation
7a6b13c
to
b1f4714
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
b1f4714
to
717166d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
5364bf7
to
13d77b0
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
e06907e
to
5759e57
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
5759e57
to
3b549a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff
I think it works as it should, I will do a review later. But without automatically adjusting to the available size, the usefulness is a bit limited, to be honest. You could achieve the same already by simply putting your inline actions as Buttons next to the |
Baby steps :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, tested in the docs and works. Awesome stuff :)
Currently, it's hardcoded, meaning we are not hecking the available space and changing the inline accordingly.
Might come later, but this is a good enough starting point