Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud/eslint-config from 8.0.0 to 8.1.2 #2980

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2022

Bumps @nextcloud/eslint-config from 8.0.0 to 8.1.2.

Release notes

Sourced from @​nextcloud/eslint-config's releases.

v8.1.2

Fixed

  • Also update eslint-config-n custom rules #381

v8.1.1

Fixed

  • Fix node plugin usage #379

v8.1.0

Changed

Changelog

Sourced from @​nextcloud/eslint-config's changelog.

v8.1.2 (2022-08-09)

Full Changelog

Dependency updates:

Commits
  • 56b5b8a 8.1.2
  • 80f238a Merge pull request #381 from nextcloud/fix/n-rules
  • 1a5a313 Also update eslint-config-n custom rules
  • 66b1d6b 8.1.1
  • 4605723 Merge pull request #379 from nextcloud/fix/eslint-plugin-n
  • 06da4e9 Fix node plugin usage
  • 21497a9 Merge pull request #378 from nextcloud/feat/package-node-npm-engines-update
  • 2d1cb92 Update npm and node engines versions
  • 4a076e6 Merge pull request #377 from nextcloud/feat/workflow-auto-update-dependabot-a...
  • 8bf7739 Updating dependabot-approve-merge.yml workflow from template
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@nextcloud/eslint-config](https://github.com/nextcloud/eslint-config) from 8.0.0 to 8.1.2.
- [Release notes](https://github.com/nextcloud/eslint-config/releases)
- [Changelog](https://github.com/nextcloud/eslint-config/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/eslint-config@v8.0.0...v8.1.2)

---
updated-dependencies:
- dependency-name: "@nextcloud/eslint-config"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Aug 9, 2022
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 9, 2022

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@raimund-schluessler raimund-schluessler added the 💥 breaking PR that requires a new major version label Aug 9, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 9, 2022
@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Aug 9, 2022

I fixed all lint errors, but that included renaming the Button component, because eslint complained that "Name "Button" is reserved in HTML" via its vue/no-reserved-component-names rule, which makes this PR breaking.

I chose to name it ButtonVue but it would be good if that was confirmed by someone.

to fix Name "Button" is reserved in HTML

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler force-pushed the dependabot/npm_and_yarn/nextcloud/eslint-config-8.1.2 branch from 085dfb6 to 05656f5 Compare August 9, 2022 09:59
@dependabot dependabot bot merged commit 8778941 into master Aug 9, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nextcloud/eslint-config-8.1.2 branch August 9, 2022 10:04
@raimund-schluessler
Copy link
Contributor

I chose to name it ButtonVue but it would be good if that was confirmed by someone.

Damn it, dependabot just merged it automatically, because the tests now pass, sorry 🙈
I guess if we want a different name than ButtonVue we need to go for a follow-up PR.

@vinicius73
Copy link
Contributor

This has introduced a BC, right @raimund-schluessler ?
I guess we must think about a good way to handle this #2643

@raimund-schluessler
Copy link
Contributor

This has introduced a BC, right @raimund-schluessler ? I guess we must think about a good way to handle this #2643

Yes, this is a breaking change, and I didn't mean to merge it without review. But since it's only in master which will be 6.0.0 it's not critical that it's breaking. However, solving it for the other components as well in #2643 makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews 💥 breaking PR that requires a new major version dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants