-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @nextcloud/eslint-config from 8.0.0 to 8.1.2 #2980
Bump @nextcloud/eslint-config from 8.0.0 to 8.1.2 #2980
Conversation
Bumps [@nextcloud/eslint-config](https://github.com/nextcloud/eslint-config) from 8.0.0 to 8.1.2. - [Release notes](https://github.com/nextcloud/eslint-config/releases) - [Changelog](https://github.com/nextcloud/eslint-config/blob/master/CHANGELOG.md) - [Commits](nextcloud-libraries/eslint-config@v8.0.0...v8.1.2) --- updated-dependencies: - dependency-name: "@nextcloud/eslint-config" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
I fixed all lint errors, but that included renaming the I chose to name it |
to fix Name "Button" is reserved in HTML Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
085dfb6
to
05656f5
Compare
Damn it, dependabot just merged it automatically, because the tests now pass, sorry 🙈 |
This has introduced a BC, right @raimund-schluessler ? |
Yes, this is a breaking change, and I didn't mean to merge it without review. But since it's only in master which will be 6.0.0 it's not critical that it's breaking. However, solving it for the other components as well in #2643 makes sense. |
Bumps @nextcloud/eslint-config from 8.0.0 to 8.1.2.
Release notes
Sourced from
@nextcloud/eslint-config
's releases.Changelog
Sourced from
@nextcloud/eslint-config
's changelog.Commits
56b5b8a
8.1.280f238a
Merge pull request #381 from nextcloud/fix/n-rules1a5a313
Also updateeslint-config-n
custom rules66b1d6b
8.1.14605723
Merge pull request #379 from nextcloud/fix/eslint-plugin-n06da4e9
Fix node plugin usage21497a9
Merge pull request #378 from nextcloud/feat/package-node-npm-engines-update2d1cb92
Update npm and node engines versions4a076e6
Merge pull request #377 from nextcloud/feat/workflow-auto-update-dependabot-a...8bf7739
Updating dependabot-approve-merge.yml workflow from templateDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)