Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not shown in Details view of specific fees #1368

Closed
stefan-niedermann opened this issue Jan 19, 2024 · 7 comments
Closed

Images not shown in Details view of specific fees #1368

stefan-niedermann opened this issue Jan 19, 2024 · 7 comments
Labels

Comments

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Jan 19, 2024

Only affected feed I am aware of:

https://comicbook.com/marvel/feed

Overview works:

Screenshot_20240119-104616_News

After opening a feed item the teaser image does not get rendered (all other images in this feed item are shown though)

Screenshot_20240119-104605_News

Any ideas?

@louim-lbs
Copy link

Could it be related to #1325?

@stefan-niedermann
Copy link
Member Author

It might be the same, yes. I'm struggling because in the other issue the fallback looks different... @David-Development feel free to close in case you think that it is the same issue

@louim-lbs
Copy link

Anyway that's an annoying issue. Good to see I'm not alone ^^

@David-Development
Copy link
Member

Thank you for the report. I believe this is a server side issue (nextcloud news server app). It looks like the missing "image" is actually an iframe without a src.

If you have a look at the feed itself there is an iframe with a src:

<content:encoded>
<![CDATA[ <div id="embedVideoContainer_161516321122021185" class="embedVideoContainer" data-video-id="3f35d290-5b97-4fe6-9431-2dbe6b844dc2"><div class="player-position"><iframe src="https://video.comicbook.com/embed/video/eyJwYXJlbnRVUkwiOiJodHRwczpcL1wvY29taWNib29rLmNvbVwvbWFydmVsXC9mZWVkXC8iLCJ2aWRlb0lkIjoiM2YzNWQyOTAtNWI5Ny00ZmU2LTk0MzEtMmRiZTZiODQ0ZGMyIiwicGxheWxpc3RJZCI6ImNyZWF0b3JzLW9uLWNyZWF0b3JzLXZpbmNlbnQtZG9ub2ZyaW8tYW5kLWRhdmlkLW1hY2sifQ==/?optanonConsent=2" id="embedVideo_161516321122021185" name="embedVideo_161516321122021185" data-video-id="3f35d290-5b97-4fe6-9431-2dbe6b844dc2" allow="autoplay; fullscreen" allowfullscreen="allowfullscreen" height="100%" width="100%"></iframe></div></div><p>All five episodes of <em><a href="https://comicbook.com/category/echo-tv-show/">Echo</a></em> <a href="https://comicbook.com/tv-shows/news/echo-review-best-mcu-disney-plus-show/">dropped on Disney+ and Hulu last week</a>, and the show's star has been sharing lots of behind-the-scenes information about bringing the series to life. <a href="https://comicbook.com/category/alaqua-cox/">Alaqua Cox</a> plays Maya Lopez/Echo, the character who was first introduced in <em>Hawkeye</em> back in 2021. Cox has talked about everything from <a href="https://comicbook.com/marvel/news/echo-alaqua-cox-surprising-reason-scenes-with-vincent-donofrio-were-very-tough-deaf/">filming scenes with Vincent D'Onofrio</a> (Wilson Fisk/Kingpin) to her love of <a href="https://comicbook.com/marvel/news/echo-star-alaqua-cox-opens-up-about-being-bullied-as-a-kid-i-can-do-anything/">getting physical in front of the camera.</a> Cox did a lot of stunt training for the series, and while <a href="https://comicbook.com/tv-shows/news/marvel-echo-alaqua-cox-mcu-stunt-training/">she didn't get to do all of the action</a> on her own, she recently talked to <a href="https://deadline.com/2024/01/echo-finale-alaqua-cox-marvel-interview-1235794333/" target="_blank"><em>Deadline</em></a> about learning fight choreography and the challenges of unexpected changes. </p><p>"Learning the new choreography," Cox said when asked what was the most difficult thing about the stunts. "I love learning choreography. Not last minute though, right before we shoot. That did happen sometimes. They would say, 'We have to switch the choreography. This will look better.' But it was on the day...and I would say, 'Right now? In five minutes? We're about to shoot the scene.' And they would say 'Nope, we got to do it now.' So we had to learn some choreography last minute. I'd say that's the most difficult part."</p><div class="modernInContent"><div id="mobile-native-plus-top1" class="mobile"></div></div><h2>What's Next For Maya Lopez?</h2><p>It's unclear when we will be seeing Maya in the MCU again, but Cox has ideas for her character's future. She previously said <a href="https://comicbook.com/marvel/news/marvels-echo-star-alaqua-cox-wants-spider-man-crossover-exclusive/">she would like to share the screen with Spider-Man</a>, and she recently told <a href="https://deadline.com/2024/01/echo-finale-alaqua-cox-marvel-interview-1235794333/" target="_blank"><em>Deadline</em></a> that <a href="https://comicbook.com/news/echo-alaqua-cox-shares-her-hopes-for-mayas-future-wants-to-join-the-avengers/">she wants to join the Avengers. </a></p><p>"Honestly, I wouldn't mind if Maya joined the Avengers," Cox revealed. "I think it would be so amazing to cross paths with other superheroes. I would love that. I think would be very fun. I think be great to work with Mark Ruffalo, the Hulk. I love him as an actor and a person, because Mark is a huge advocate for Indigenous women. And he's from Wisconsin, and I'm from Wisconsin. So we have that in common. But Mark is just an amazing advocate for women, and I think it'd be amazing to work with him. I think that we would have a lot of things to talk about. I can just imagine those conversations already." </p><div class="modernInContent"><div id="native-plus-top1"></div></div><h2>What Is <em>Echo</em> About?</h2><p>Starring <a href="https://comicbook.comhttps://comicbook.com/category/alaqua-cox/" target="_blank">Alaqua Cox</a>, all five episodes of <em><a href="https://comicbook.comhttps://comicbook.com/category/echo-tv-show/" target="_blank">Echo</a></em> debuted exclusively on both Disney+ and Hulu on Tuesday, January 9th. The origin story of <em><a href="https://comicbook.comhttps://comicbook.com/category/echo-tv-show/" target="_blank">Echo</a></em> revisits Maya Lopez, whose ruthless behavior in New York City catches up with her in her hometown. She must face her past, reconnect with her Native American roots and embrace the meaning of family and community if she ever hopes to move forward. <a href="https://comicbook.comhttps://comicbook.com/category/vincent-donofrio/" target="_blank">Vincent D'Onofrio</a> will reprise his role as Wilson Fisk / Kingpin, and <a href="https://comicbook.comhttps://comicbook.com/category/charlie-cox/" target="_blank">Charlie Cox</a> will reprise his role as Matt Murdock / Daredevil. <em><a href="https://comicbook.comhttps://comicbook.com/category/echo-tv-show/" target="_blank">Echo</a></em> will also star Chaske Spencer, Tantoo Cardinal, Devery Jacobs, Cody Lightning, Graham Greene, and Zahn McClarnon.</p><div class="modernInContent"><div id="mobile-native-plus-top2" class="mobile"></div></div><p>Kevin Feige, Louis D'Esposito, Victoria Alonso, Brad Winderbaum, Stephen Broussard, Richie Palmer, Marion Dayre, and Jason Gavin (<em>Blackfeet</em>) are executive producers of <em><a href="https://comicbook.comhttps://comicbook.com/category/echo-tv-show/" target="_blank">Echo</a></em>. Amy Rardin, Sydney Freeland, Christina King (<em>Seminole</em>), and Jennifer Booth are co-executive producers.</p><p><em>Echo</em> is now streaming on Disney+ and Hulu, and will leave Hulu on April 9th.</p><div class="modernInContent"><div id="native-plus-top2"></div><div id="mobile-native-plus-top3" class="mobile"></div></div><a class="mid-content-comment js-activateComments" data-key="487405" data-root="#comments" href="#"><span>{replyCount}</span><span>comments</span></a> ]]>
</content:encoded>

in particular this part:

<iframe src="https://video.comicbook.com/embed/video/eyJwYXJlbnRVUkwiOiJodHRwczpcL1wvY29taWNib29rLmNvbVwvbWFydmVsXC9mZWVkXC8iLCJ2aWRlb0lkIjoiM2YzNWQyOTAtNWI5Ny00ZmU2LTk0MzEtMmRiZTZiODQ0ZGMyIiwicGxheWxpc3RJZCI6ImNyZWF0b3JzLW9uLWNyZWF0b3JzLXZpbmNlbnQtZG9ub2ZyaW8tYW5kLWRhdmlkLW1hY2sifQ==/?optanonConsent=2" id="embedVideo_161516321122021185" name="embedVideo_161516321122021185" data-video-id="3f35d290-5b97-4fe6-9431-2dbe6b844dc2" allow="autoplay; fullscreen" allowfullscreen="allowfullscreen" height="100%" width="100%"></iframe></div></div><p>All five episodes of 

If you query the nextcloud API you get the following result (iframe but without the src):

<div><div><iframe allowfullscreen=\"\" height=\"100%\" width=\"100%\"></iframe></div></div><p>All five episodes of

@Grotax Do you guys have some sort of sanitation on the server that removes src attributes etc. from iframes?


curl -u david https://xyz.com/index.php/apps/news/api/v1-2/items | jq | grep "echo-review-best-mcu-disney-plus-sh"

@stefan-niedermann
Copy link
Member Author

In this case a

iframe:not([src]) { display: none }

might help in case the server isn't able to sanitize it?

Then the question is, why is the image missing (and in oppose to #1325 without a fallback image)?

@Grotax
Copy link
Member

Grotax commented Jan 21, 2024

We have html purifier in the server app, it's possible that it deletes the src.

@David-Development
Copy link
Member

Great idea Stefan! Thank you!

Okay, thank you @Grotax !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants