Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission date not in locale format #1856

Closed
QQ7QQ7 opened this issue Dec 27, 2023 · 2 comments · Fixed by nextcloud-libraries/nextcloud-moment#781 or #1872
Closed

Submission date not in locale format #1856

QQ7QQ7 opened this issue Dec 27, 2023 · 2 comments · Fixed by nextcloud-libraries/nextcloud-moment#781 or #1872
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working javascript Javascript related ticket regression Regression of a previous working feature upstream Blocked or cause by an upstream issue

Comments

@QQ7QQ7
Copy link

QQ7QQ7 commented Dec 27, 2023

Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug
It seems that the submission date that is shown in "Results -> Responses" is not affected by the locale that the user has selected.

To Reproduce
Steps to reproduce the behavior:

  1. Create a form
  2. Submit to the form
  3. Change your locale to "German (Germany)"
  4. Open the Results of the form
  5. Change the view to "Resonses"
  6. The submission date is displayed in english

Expected behavior
The submission date should be displayed in the selected locale format.

Screenshots
Submission date in Responses:
image

Selected locale:
image

Nextcloud (please complete the following information):

  • Nextcloud-Version: 28.0.1
  • Forms-Version: 4.0.0

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Microsoft Edge
  • Version: 120.0.2210.91
@QQ7QQ7 QQ7QQ7 added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Dec 27, 2023
@Chartman123 Chartman123 added good first issue Good for newcomers javascript Javascript related ticket 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Dec 27, 2023
@Chartman123
Copy link
Collaborator

@susnux Any idea why nextcloud-moment no longer provides the localized output?

@susnux
Copy link
Collaborator

susnux commented Jan 9, 2024

This seems to be related to tree shaking because the locales are not imported for moment thus they are removed. Fixed this on the nextcloud-moment package. See nextcloud-libraries/nextcloud-moment#781

@Chartman123 Chartman123 added pending fix Waiting for a fix on one of our dependencies upstream Blocked or cause by an upstream issue and removed good first issue Good for newcomers labels Jan 10, 2024
@Chartman123 Chartman123 added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Jan 10, 2024
@Chartman123 Chartman123 removed the pending fix Waiting for a fix on one of our dependencies label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working javascript Javascript related ticket regression Regression of a previous working feature upstream Blocked or cause by an upstream issue
Projects
None yet
3 participants