-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a subline to each of the address books, explain what an address book is #3320
Comments
@GretaD can you be more elaborate with what needs to be done? |
@nimishavijay can you please help with a screenshot |
This is in the settings modal, a subline can be added like this: There can also be a short explanation about what exactly an address book is below the heading. pinging @jancborchardt for help here because I am not sure I understand address books fully either 🙈 :D |
The component contacts() {
return Object.values(this.addressbook.contacts)
}, Groups (vcard CATEGORIES) are slightly more tricky. They are found on the vCard property of each contact. We can flatmap them into one combined list and then deduplicate the entries: groups() {
const allGroups = this.contacts
.flatMap(contact => contact.vCard.getAllProperties('categories').map(prop => prop.getFirstValue()))
// Deduplicate
return [...new Set(allGroups)]
}, These two computed array properties can be used to render counters in the template. |
@ChristophWurst could you please grant me permission to the repo so I can push my local branch? |
Please fork the repo and push to the fork: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork :) |
Is your feature request related to a problem? Please describe.
It would be helpful if:
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: