Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact details: Improve experience of adding a new property #2969

Closed
2 tasks done
Tracked by #2953
st3iny opened this issue Sep 23, 2022 · 2 comments
Closed
2 tasks done
Tracked by #2953

Contact details: Improve experience of adding a new property #2969

st3iny opened this issue Sep 23, 2022 · 2 comments
Labels
4. to release Ready to be released and/or waiting for tests to finish design review Issues that were triaged during a design review design Related to the design enhancement New feature or request feature: contacts

Comments

@st3iny
Copy link
Member

st3iny commented Sep 23, 2022

Is your feature request related to a problem? Please describe.

The "Add new property" section at the bottom could be improved visually. It makes more sense to use a button than a select for this.

Describe the solution you'd like

  • Convert the select "Choose property type" to a button and expand it to full width (because it doesn't have a label). Clicking the button should show a popover containing all possible property options (-> using an Actions component with a :menu-title should work).
  • Get rid of the section header "Add new property". A labeled button is self explanatory.

Describe alternatives you've considered

No response

Additional context

No response

@st3iny st3iny added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of design Related to the design feature: contacts design review Issues that were triaged during a design review labels Sep 23, 2022
@ChristophWurst ChristophWurst added this to the v5.0 milestone Sep 26, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Sep 26, 2022
@ChristophWurst ChristophWurst modified the milestones: v5.0, v5.1 Oct 14, 2022
@st3iny st3iny modified the milestones: v5.1.0, v5.2.0 Feb 2, 2023
@st3iny st3iny modified the milestones: v5.2.0, v5.3.0 Mar 27, 2023
@st3iny
Copy link
Member Author

st3iny commented May 16, 2023

Fixed by #3314.

@st3iny st3iny closed this as completed May 16, 2023
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 💌 📅 👥 Groupware team May 16, 2023
@st3iny st3iny removed this from the v5.3.0 milestone May 16, 2023
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels May 16, 2023
@st3iny
Copy link
Member Author

st3iny commented May 16, 2023

The PR is already on the milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design review Issues that were triaged during a design review design Related to the design enhancement New feature or request feature: contacts
Projects
Development

No branches or pull requests

2 participants