Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contacts list: Migrate contacts list to common list component #2950

Closed
Tracked by #2953
st3iny opened this issue Sep 21, 2022 · 0 comments · Fixed by #3030
Closed
Tracked by #2953

Contacts list: Migrate contacts list to common list component #2950

st3iny opened this issue Sep 21, 2022 · 0 comments · Fixed by #3030
Assignees
@JuliaKirschenheuter
Labels
3. to review Waiting for reviews design review Issues that were triaged during a design review design Related to the design enhancement New feature or request feature: contacts
Milestone
v5.0

Comments

@st3iny
Copy link
Member

st3iny commented Sep 21, 2022

Is your feature request related to a problem? Please describe.

The contacts list is not consistent with the common Nextcloud design. It should have rounded corners and the hover/active state don't use the primary color.

Contacts Mail
image image

Describe the solution you'd like

It should look like lists in other apps. It should have rounded corners and use the correct background color on hover/active.

Describe alternatives you've considered

No response

Additional context

No response
@st3iny st3iny added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of design Related to the design design review Issues that were triaged during a design review feature: contacts labels Sep 21, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Sep 21, 2022
@st3iny st3iny changed the title Migrate contacts list to common list component Left sidebar: Migrate contacts list to common list component Sep 23, 2022
@st3iny st3iny changed the title Left sidebar: Migrate contacts list to common list component Contacts list: Migrate contacts list to common list component Sep 23, 2022
@st3iny st3iny mentioned this issue Sep 23, 2022
Closed
16 tasks
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Oct 10, 2022
@ChristophWurst ChristophWurst added this to the v5.0 milestone Oct 10, 2022
@JuliaKirschenheuter JuliaKirschenheuter mentioned this issue Oct 10, 2022
Merged
@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 10, 2022
Repository owner moved this from 📄 To do (~10 entries) to ☑️ Done in 💌 📅 👥 Groupware team Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews design review Issues that were triaged during a design review design Related to the design enhancement New feature or request feature: contacts
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Replace ListItemIcon with ListItem and fix styles nextcloud/contacts
3 participants
@ChristophWurst @st3iny @JuliaKirschenheuter