Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download contact pictures from Xing #1868

Closed
ntimo opened this issue Oct 20, 2020 · 7 comments · Fixed by #1869
Closed

Download contact pictures from Xing #1868

ntimo opened this issue Oct 20, 2020 · 7 comments · Fixed by #1869
Labels
3. to review Waiting for reviews enhancement New feature or request

Comments

@ntimo
Copy link

ntimo commented Oct 20, 2020

Is your feature request related to a problem? Please describe.
When setting Xing as a social media profile for contacts, the profile picture is not automatically downloaded and updated.

Describe the solution you'd like
Nextcloud contacts should update profile pictures using Xing.

@ntimo ntimo added 0. Needs triage enhancement New feature or request labels Oct 20, 2020
@call-me-matt
Copy link
Member

call-me-matt commented Oct 20, 2020

I would love to implement this! In order to do so, I need a "recipe" (or public API) to fetch the profile picture from there. I found those for facebook, instagram, twitter, tumblr, mastodon, and diaspora. But xing and linkedin seem to lock their network from external access. (And currently I don't know how we could include those APIs that require keys).

@call-me-matt call-me-matt added needs info Not enough information provided and removed 0. Needs triage labels Oct 20, 2020
@call-me-matt
Copy link
Member

ah well, turns out the profile pictures are public. yay!

@call-me-matt
Copy link
Member

@skjnldsv should Xing be part of the selection-list?
src/models/rfcProps.js: { id: 'XING', name: 'Xing', placeholder: 'https://www.xing.com/profile/…' },

@skjnldsv
Copy link
Member

@skjnldsv should Xing be part of the selection-list?
src/models/rfcProps.js: { id: 'XING', name: 'Xing', placeholder: 'https://www.xing.com/profile/…' },

I guess? Hard to tell, those properties are most likely not super standard 😬

@call-me-matt
Copy link
Member

I guess?

I'll let you decide. Also if that's part of the above or a separate PR...

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed needs info Not enough information provided labels Oct 21, 2020
@ntimo
Copy link
Author

ntimo commented Oct 21, 2020

Thanks for adding this so fast :)

@skjnldsv
Copy link
Member

Yes, thanks @call-me-matt 🚀 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants