Missing UID in contact data

[milgner]

Steps to reproduce

1. Upgraded to Nextcloud 11, contacts app 1.5.3
2. Open contacts app
3. Javascript console shows error:

contact_model.js:30 Uncaught (in promise) TypeError: Cannot read property 'value' of undefined
    at Contact.uid (contact_model.js:30)
    at contact_service.js:37

4. Spinning wheel, no contacts shown.

Expected behaviour

My contacts should be displayed :)

Actual behaviour

It looks like the app is trying to access the UID property and there isn't any. I debugged into the code in question which says

return model.getProperty('uid').value;

Accessing other data like email() works just fine. So now I'm wondering why it suddenly complains about a missing UID and whether there might have been a migration that was supposed to run but didn't during upgrade?
Is there any way to add new UID to those contacts missing them?

I know my way around MySQL so if you have an idea what should go where, I'll gladly write a migration script myself 😉

[skjnldsv]

I don't see why a contact won't have any uid set!
importing create uid for each before storing it to the db and the dav server will refuse any vcard without uid. Did you edit your database?

[milgner]

Yes, it's quite baffling. I did not edit the database. The CardDAV sync on my phone works just fine, too.

[skjnldsv]

Hum, could come from an external sync indeed. We need to prevent this from happening.

[irgendwie]

Aren't cards without an UID rejected by the carddav backend in nextcloud/server?

[skjnldsv]

Apparently not! 🤔

[skjnldsv]

UIDs are automatically created on import and create in the contacts app. This needs to be created on https://github.com/nextcloud/server

[wirepatch]

Since my issue may not be uid related I've created a new issue at #358

[skjnldsv]

Look at your nextcloud.log file into the data folder! :)