Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELATED property incorrectly formatted - sync fails #1395

Closed
spoorun opened this issue Jan 4, 2020 · 6 comments
Closed

RELATED property incorrectly formatted - sync fails #1395

spoorun opened this issue Jan 4, 2020 · 6 comments
Labels
0. Needs triage bug Something isn't working

Comments

@spoorun
Copy link

spoorun commented Jan 4, 2020

ISSUE

Create a contact in Nextcloud Contacts add a 'related' field set, and enter a name or other free text:

E.g.
Mary J Blige
Sister: Theresa May

Using DavX, the related field will not sync to Android devices (and other systems) and will be lost.

Create the same field on an Android device, and the related field will correctly display on Nextcloud.

CAUSE:

https://tools.ietf.org/html/rfc6350#page-42
Specifies that the RELATED property can either contain a URI value or a TEXT value.
The default is URI. If a TEXT value is entered then it must be specified.

On Android when a free text value is entered in the RELATED field, it creates a vCard record like this:
RELATED;TYPE=sister;VALUE=TEXT:Theresa May

In Nextcloud contacts when a free text value is entered it creates a vCard record like this:
RELATED;TYPE=SISTER:Teresa May

In accordance with the RFC, since no TEXT value is declared, and since 'Teresa May' is not a valid URI, it is an error and is not synced.

SOLUTION
If free text is entered, specify 'VALUE=TEXT'

@spoorun spoorun added 0. Needs triage bug Something isn't working labels Jan 4, 2020
@spoorun spoorun changed the title RELATED property not correctly formatted by Nextcloud - sync fails RELATED property incorrectly formatted - sync fails Jan 4, 2020
@spoorun
Copy link
Author

spoorun commented Jan 5, 2020

Also there should be a picker for creating a URI link to a contact in the addressbook, #669 seems to relate to this.

@skjnldsv
Copy link
Member

skjnldsv commented Sep 7, 2020

Closing in favour of #669

@skjnldsv skjnldsv closed this as completed Sep 7, 2020
@spoorun
Copy link
Author

spoorun commented Oct 20, 2020

This does not appear to be the same as #669 , @skjnldsv - could you consider reopening or explaining how that bug covers this one - in case I've missed something?
This current issue is a bug about data loss occurring in the current implementation when syncing from Nextcloud to Android (via DavX). The suggested replacement issue is a proposed enhancement to allow direct links between contacts ...
Many thanks

@skjnldsv
Copy link
Member

#669 is because we force URL as default. Thus why is your issue appearing.
Despite the text you're entering, it is seen as an url (invalid sure, but parsed as is nonetheless)

Having a proper Picker to automatically fill the url and parse any free-typed text as, well, TEXT, is all in the other issue :)

@spoorun
Copy link
Author

spoorun commented Oct 22, 2020

#669 is because we force URL as default. Thus why is your issue appearing.
Despite the text you're entering, it is seen as an url (invalid sure, but parsed as is nonetheless)

Having a proper Picker to automatically fill the url and parse any free-typed text as, well, TEXT, is all in the other issue :)

Thank you for explaining and addressing

@spoorun
Copy link
Author

spoorun commented Dec 19, 2020

@skjnldsv Just reconsidering this, the bug described here does not seem to be fixed by #669, so it seems this bug should be reopened?

The RFC specifies that 'RELATED' can contain a URI or or a text value. Nextcloud does not sync if a text value is entered. That is a bug, and not one that appears to be resolved by #669 which appears to allow linking to another contact, not free text entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants