Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic repair of duplicate types #1042

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Automatic repair of duplicate types #1042

merged 1 commit into from
Apr 8, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 6, 2019 •
edited
Loading

Fix #1030

@j-ed

BEGIN:VCARD
VERSION:3.0
N:Doe;John;;;
FN:John Doe
UID:06070024-a509-42c7-a4x4-b08135d7183b
EMAIL;TYPE=WORK,WORK,pref:address@nowhere.com
END:VCARD

Once opened and edited, the vcard should be fixed and the EMAIL TYPE should be "WORK,pref"

Test release:
contacts.tar.gz

@skjnldsv
Automatic repair of duplicate types
c37000e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews labels Apr 6, 2019
@skjnldsv skjnldsv added this to the next milestone Apr 6, 2019
@skjnldsv skjnldsv self-assigned this Apr 6, 2019
@skjnldsv skjnldsv mentioned this pull request Apr 6, 2019
Closed
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 6, 2019

@j-ed once merge, I'll bundle the next 3.1.0 release and publish it :)

@codecov

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv merged commit e0decd5 into master Apr 8, 2019
@skjnldsv skjnldsv deleted the enhancement/repair/duplicate-types branch April 8, 2019 15:18
@skjnldsv skjnldsv modified the milestones: next, 3.1.0 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

An email address label is not set if the address type is given twice
1 participant
@skjnldsv