Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NcNoteCard padding and alignment #5886

Closed
3 tasks
jancborchardt opened this issue Jul 31, 2024 · 0 comments · Fixed by #5893
Closed
3 tasks

NcNoteCard padding and alignment #5886

jancborchardt opened this issue Jul 31, 2024 · 0 comments · Fixed by #5893
Labels
0. to triage design Design, UX, interface and interaction design enhancement New feature or request feature: note-card Related to the note-card component

Comments

@jancborchardt
Copy link
Contributor

Now with the new smaller spacing everywhere, the padding of NcNoteCard looks a bit large. (Noticed when looking at nextcloud/server#46892 )

  • The padding can be reduced to be a bit more in line with the buttons
  • Move the left icon to the top so it’s top-aligned – it seems to be the case in the docs but not in the linked issue?
  • The alignment of the icon and heading is off when a heading is used in the NoteCard, as in the docs (screenshot below)

https://next--nextcloud-vue-components.netlify.app/#/Components/NcNoteCard
image
@jancborchardt jancborchardt added enhancement New feature or request design Design, UX, interface and interaction design 0. to triage feature: note-card Related to the note-card component labels Jul 31, 2024
@jancborchardt jancborchardt moved this to 👓 Design review in 🖍 Design team Jul 31, 2024
@susnux susnux mentioned this issue Aug 2, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. to triage design Design, UX, interface and interaction design enhancement New feature or request feature: note-card Related to the note-card component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(NcNoteCard): Adjust padding and margin nextcloud-libraries/nextcloud-vue
1 participant
@jancborchardt