Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rich 12.x.x #2628

Closed
YevheniiSemendiak opened this issue Mar 16, 2022 · 1 comment
Closed

Support Rich 12.x.x #2628

YevheniiSemendiak opened this issue Mar 16, 2022 · 1 comment
Assignees
@asvetlov

Comments

@YevheniiSemendiak
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Recently, Rich has released a new major version (https://github.com/Textualize/rich/releases/tag/v12.0.0), which broke tests in this package.
We should support it or limit the upper version bound https://github.com/neuro-inc/neuro-cli/blob/master/neuro-cli/setup.cfg#L47
@YevheniiSemendiak YevheniiSemendiak mentioned this issue Mar 16, 2022
Closed
@andriihomiak andriihomiak mentioned this issue Mar 17, 2022
Merged
@romasku romasku self-assigned this Apr 7, 2022
@eviltwinhans eviltwinhans assigned asvetlov and unassigned romasku May 11, 2022
@asvetlov
Copy link
Contributor

Tests for this package are passed now.
Rich 12 works fine with neuro-cli.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asvetlov asvetlov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asvetlov @romasku @YevheniiSemendiak