Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

fix(network): give up peer because of handshake timeout #418

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Aug 13, 2020

What this PR does / why we need it:
Right now, we will give up a peer after secio handshake timeout. This PR handle this timeout error, instead
of give up peer, we just increase its address failure count, so that we can try this peer again.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

@zeroqn
Copy link
Contributor Author

zeroqn commented Aug 13, 2020

/test chaos

@muta-robot
Copy link

@zeroqn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
chaos 339cda1 link /test chaos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@yejiayu
Copy link
Contributor

yejiayu commented Aug 13, 2020

/lgtm

@muta-robot muta-robot added the lgtm #8ef42e label Aug 13, 2020
@muta-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yejiayu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yejiayu yejiayu merged commit 2627c00 into nervosnetwork:master Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants