Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

fix(consensus): recover and insert tx to mempool to avoid inactivation #414

Merged
merged 3 commits into from
Aug 18, 2020

Conversation

KaoImin
Copy link

@KaoImin KaoImin commented Aug 12, 2020

What this PR does / why we need it:

  1. Fix a bug that may cause inactivation. Recover signed transactions from wal when reboot. Then insert them to the mempool.
  2. Add a check of the ordered transaction hash when commit.
  3. Upgrade overlord version.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

@KaoImin KaoImin requested review from yejiayu and rev-chaos and removed request for yejiayu August 13, 2020 01:23
@KaoImin
Copy link
Author

KaoImin commented Aug 13, 2020

/hold

@KaoImin KaoImin requested a review from yejiayu August 13, 2020 02:20
@KaoImin KaoImin force-pushed the upgrade-overlord branch 2 times, most recently from 386c0b7 to 9a7e330 Compare August 13, 2020 07:40
fix(consensus): recover and insert current txs

add log

add unit test

cargo clippy
@muta-robot muta-robot added size/L and removed size/M labels Aug 17, 2020
@KaoImin
Copy link
Author

KaoImin commented Aug 17, 2020

/test unit

@KaoImin
Copy link
Author

KaoImin commented Aug 18, 2020

/hold cancel

@yejiayu
Copy link
Contributor

yejiayu commented Aug 18, 2020

/test chaos

@KaoImin
Copy link
Author

KaoImin commented Aug 18, 2020

/test chaos

@LycrusHamster
Copy link
Contributor

/lgtm

@muta-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LycrusHamster

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muta-robot muta-robot merged commit fd9716e into nervosnetwork:master Aug 18, 2020
@KaoImin KaoImin deleted the upgrade-overlord branch August 18, 2020 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants