This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
feat(sync): Limit the maximum height of once sync #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yejiayu
changed the title
| let remote_height = if current_height + ONCE_SYNC_BLOCK_LIMIT > remote_height { | ||
| remote_height | ||
| } else { | ||
| remote_height + ONCE_SYNC_BLOCK_LIMIT |
There was a problem hiding this comment.
current_height + ONCE_SYNC_BLOCK_LIMIT
|
/hold wait tests |
|
/retest |
1 similar comment
|
/retest |
|
/hold cancel test pass |
|
/lgtm |
KaoImin
approved these changes
Aug 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KaoImin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does / why we need it:
Each successful download of 50 blocks will complete synchronization to avoid downloading too many blocks from a single node, which will affect the success rate of network transmission.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: