Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

perf(mempool): parallel verifying signatures in mempool #359

Merged
merged 2 commits into from
Jul 21, 2020
Merged

perf(mempool): parallel verifying signatures in mempool #359

merged 2 commits into from
Jul 21, 2020

Conversation

KaoImin
Copy link

@KaoImin KaoImin commented Jul 15, 2020

What type of PR is this?
perf

What this PR does / why we need it:

  • make verifying signatures in mempool parallelly.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@muta-robot muta-robot requested review from homura and yejiayu July 15, 2020 09:09
@yejiayu
Copy link
Contributor

yejiayu commented Jul 16, 2020

/test chaos

1 similar comment
@KaoImin
Copy link
Author

KaoImin commented Jul 16, 2020

/test chaos

@KaoImin KaoImin changed the title perf(mempool): parallel verifying signatures perf(mempool): parallel verifying signatures in mempool Jul 16, 2020
@yejiayu
Copy link
Contributor

yejiayu commented Jul 16, 2020

/test all

1 similar comment
@yejiayu
Copy link
Contributor

yejiayu commented Jul 16, 2020

/test all

@KaoImin
Copy link
Author

KaoImin commented Jul 16, 2020

/test pr-build

@yejiayu
Copy link
Contributor

yejiayu commented Jul 17, 2020

/test all

@KaoImin
Copy link
Author

KaoImin commented Jul 20, 2020

/retest

@yejiayu
Copy link
Contributor

yejiayu commented Jul 21, 2020

/test all

@muta-robot
Copy link

muta-robot commented Jul 21, 2020 •
edited
Loading

@KaoImin: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr-build 90f68fa link /test this
chaos 90f68fa link /test chaos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@KaoImin
Copy link
Author

KaoImin commented Jul 21, 2020

/retest unit

@KaoImin
Copy link
Author

KaoImin commented Jul 21, 2020

/test unit

@yejiayu
Copy link
Contributor

yejiayu commented Jul 21, 2020

/lgtm

@muta-robot muta-robot added the lgtm #8ef42e label Jul 21, 2020
@muta-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yejiayu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muta-robot muta-robot merged commit 2ccdf1a into nervosnetwork:master Jul 21, 2020
@KaoImin KaoImin deleted the perf branch July 21, 2020 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@homura homura Awaiting requested review from homura

@yejiayu yejiayu Awaiting requested review from yejiayu

Assignees

@yejiayu yejiayu

Labels
approved lgtm #8ef42e size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaoImin @yejiayu @muta-robot