Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Clojure Map Interop #208

Closed
ducky427 opened this issue Aug 2, 2016 · 4 comments
Closed

Issue with Clojure Map Interop #208

ducky427 opened this issue Aug 2, 2016 · 4 comments

Comments

@ducky427
Copy link

ducky427 commented Aug 2, 2016

A Clojure map both implements the interfaces - java.util.Map and java.lang.Iterable.

Currently while encoding the data, the latter interface is used and not the former. See Value.value method.

It would be better to use the former. So if value is a instance of Map should be moved up in the method.

Thank you.

@zhenlineo
Copy link
Contributor

#209
CC @boggle I failed to think of any difference the change in above PR would make to java, but maybe there is another language concerns? What do you think of this topic?

@ducky427
Copy link
Author

ducky427 commented Aug 2, 2016

Over the longer term, it would be nice to have a proper mechanism to register how to encode data which the driver doesn't know about.

@zhenlineo
Copy link
Contributor

If you really really want to define how you could interpret a data undefined, you might find implementing AsValue interface useful. But AsValue interface is internal use only, so we will make any promise to keep it same over versions.

@zhenlineo
Copy link
Contributor

I am closing this issue as the fix already merged and a release with fix 1.0.5 has already be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants