Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch does not match React Native implementation #1492

Closed
Arlen22 opened this issue Nov 25, 2019 · 2 comments
Closed

Switch does not match React Native implementation #1492

Arlen22 opened this issue Nov 25, 2019 · 2 comments

Comments

@Arlen22
Copy link

Arlen22 commented Nov 25, 2019

In React Native the thumb is one color, and the track changes color when switched, and this is controlled by two properties. However, in React Native Web, there are 4 properties, at least according to #832. However, nothing is listed in the Readme about Switch being any different from React Native. Even though I like this idea, React Native Web should rather match React Native in order to avoid edge cases.

@Arlen22
Copy link
Author

Arlen22 commented Nov 25, 2019

Update: after playing around with the colors a little, I decided that the React Native system of keeping the same thumb color and changing the track color between a neutral color and a tertiary color looked about the nicest.

@necolas
Copy link
Owner

necolas commented Dec 18, 2019

aa8593b

@necolas necolas closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants