Running tests yields errors

[jh3y]

Environment

• graphql-hooks version: 3.1.1
• react version: 16.8.3
• Browser: N/A

Description

Running npm run test yields several errors although the tests pass.

Warning: An update to TestHook inside a test was not wrapped in act(...).

      When testing, code that causes React state updates should be wrapped into act(...):

      act(() => {
        /* fire events that update state */
      });
      /* assert on the output */

      This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act

I believe the errors are printed when running useQuery.test.js and useClientRequest.test.js.

How to reproduce

npm run test

Suggested solution (optional)

• Potential versioning issue?

[jackdclark]

This was introduced in #32. I've added a comment explaining what the issue is in the test file but we're waiting to see what happens with this react issue facebook/react#14769.

[threepointone]

we just released an alpha with async act() implementation that should solve these issues (assuming you were having trouble with an async test). the link in your comment doesn't work anymore? lemme know if you have issues with the alpha, and I'd be happy to pitch in and help fix it.

[bmullan91]

@threepointone ah the comment link got lost after the lerna move. Here it is: https://github.com/nearform/graphql-hooks/blob/master/packages/graphql-hooks/test/unit/useClientRequest.test.js#L262-L281

Great work on facebook/react#14853 btw - I've just tried 16.9.0-alpha.0 locally and all the big scaryWarning: An update to TestHook inside a test was not wrapped in act(...). logs are gone 🎉

[bmullan91]

Fixed in #412

[nuragic]

We still have this console error when running unit tests: Warning: An update to TestComponent inside a test was not wrapped in act(...).

I've also found that in #604 @salmanm talk about these warnings and suggest that the proposed solution would avoid them.

[simoneb]

Shall we fail the build when those warnings happen? Or we'll keep introducing them