Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the MOVE and CANCEL behaviours on Assets #6558

Open
ripienaar opened this issue Feb 21, 2025 · 0 comments
Open

Fix the MOVE and CANCEL behaviours on Assets #6558

ripienaar opened this issue Feb 21, 2025 · 0 comments
Labels
2.12 accepted The defect or proposal as been accepted bug Confirmed reproducible bug needs design Needs design or ADR proposal Enhancement idea or proposal

Comments

@ripienaar
Copy link
Contributor

ripienaar commented Feb 21, 2025

Proposed change

There are several consistency and behaviour issues with moving assets:

  • It's quite brittle and bandwidth expensive
  • If it fails or get cancelled the stream might end up with the incorrect configuration - tags that does not reflect where the stream actually runs
  • The cancel API is poorly implemented and does not respond with useful data
  • The cancel API is not in the user account

There are some back story in nats-io/natscli#724 (comment)

Dereks suggest we might pick 1 node in the target tag/cluster and bring it up to current, then make that the leader and only then expand the replicas in the target location so they sync from the leader that is then in their cluster. This would greatly improve the performance and cost of super cluster moves.

This might be a bug fix in 2.11.x

Use case

We want to build tooling that proactively balances clusters using moves and cancels, users need to be able to do so manually without fear.

Contribution

No response

@ripienaar ripienaar added 2.12 accepted The defect or proposal as been accepted bug Confirmed reproducible bug needs design Needs design or ADR proposal Enhancement idea or proposal labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12 accepted The defect or proposal as been accepted bug Confirmed reproducible bug needs design Needs design or ADR proposal Enhancement idea or proposal
Projects
None yet
Development

No branches or pull requests

1 participant