Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject API requests with invalid JSON fields #6539

Open
ripienaar opened this issue Feb 21, 2025 · 1 comment
Open

Reject API requests with invalid JSON fields #6539

ripienaar opened this issue Feb 21, 2025 · 1 comment
Labels
2.12 accepted The defect or proposal as been accepted proposal Enhancement idea or proposal

Comments

@ripienaar
Copy link
Contributor

ripienaar commented Feb 21, 2025 •
edited
Loading

Proposed change

Today when receiving JSON fields in API requests that have invalid flags we accept them but log about it. These requests should be rejected.

See ADR-44

Use case

Toward safety in using new clients on old servers, this will ensure that attempts to use new features will fail.
@ripienaar ripienaar added 2.12 accepted The defect or proposal as been accepted proposal Enhancement idea or proposal labels Feb 21, 2025
@ripienaar ripienaar mentioned this issue Feb 21, 2025
Open
@ripienaar
Copy link
Contributor Author

Related #704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.12 accepted The defect or proposal as been accepted proposal Enhancement idea or proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ripienaar