Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon model HTML report could use a visual refresh #1732

Closed
emilyanndavis opened this issue Jan 9, 2025 · 1 comment · Fixed by #1750
Closed

Carbon model HTML report could use a visual refresh #1732

emilyanndavis opened this issue Jan 9, 2025 · 1 comment · Fixed by #1750
Assignees
Milestone

Comments

@emilyanndavis
Copy link
Member

The HTML report generated by the carbon model is perfectly functional, but it looks a little dated. Specifically—from a purely visual standpoint—it doesn't appear to be related to the current Workbench.

Updating the text styles and text/background/border colors to align with current branding/Workbench styling wouldn't take much effort, but it could help create a more seamless user experience.

Ideally, we'd make use of CSS variables that are shared by the Workbench so that the carbon model HTML report—along with any other HTML documents generated by InVEST models in the future—can keep up with future styling/branding updates with minimal effort.

@emilyanndavis emilyanndavis self-assigned this Jan 23, 2025
@emilyanndavis
Copy link
Member Author

I spent some time thinking through how we might export styles from the Workbench in a form that can be imported by the carbon module, but after chatting with @davemfish, I decided implementing such an approach would be over-engineering at this point. The carbon model is the only model that currently generates an HTML report, and in the future, there's a non-zero chance we will render such HTML reports directly in the Workbench rather than generating standalone files. We'll definitely keep modularity in mind as we plan for future updates, but for now, I'm just going to update the styles that are hard-coded in the carbon module.

@emilyanndavis emilyanndavis added the in progress This issue is actively being worked on label Jan 25, 2025
@emilyanndavis emilyanndavis added this to the 3.14.4 milestone Jan 28, 2025
@emilyanndavis emilyanndavis removed the in progress This issue is actively being worked on label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant