Merge pull request #2662 from natalie-lang/remove-rubocop-comments

Author: seven1m

CONTRIBUTING.md

@@ -10,8 +10,7 @@ direction. If you are not sure about this, open an issue first so we can discuss
 
 ## Code Formatting
 
-- Use `clang-format` to automatically format C++ files. You can run `rake format`.
-- Use `rubocop` to keep Ruby style and usage consistent.
+- Use `clang-format` to automatically format C++ files and `syntax_tree` for Ruby files. You can run `rake format`.
 
 ## Tests
 

Rakefile

@@ -357,16 +357,16 @@ end
 # # # # Build Compile Database # # # #
 
 if system('command -v compiledb 2>&1 >/dev/null')
-  $compiledb_out = [] # rubocop:disable Style/GlobalVars
+  $compiledb_out = []
 
   def $stderr.puts(str)
     write(str + "\n")
-    $compiledb_out << str # rubocop:disable Style/GlobalVars
+    $compiledb_out << str
   end
 
   task :write_compile_database do
-    if $compiledb_out.any? # rubocop:disable Style/GlobalVars
-      File.write('build/build.log', $compiledb_out.join("\n")) # rubocop:disable Style/GlobalVars
+    if $compiledb_out.any?
+      File.write('build/build.log', $compiledb_out.join("\n"))
       sh 'compiledb < build/build.log'
     end
   end

lib/date.rb

@@ -334,7 +334,7 @@ def step(limit, step = 1)
     end
   end
 
-  def strftime(format = '%F') # rubocop:disable Lint/UnusedMethodArgument
+  def strftime(format = '%F')
     __inline__ <<-END
       format_var.assert_type(env, Object::Type::String, "String");
       struct tm time = { 0 };

lib/fiddle.rb

@@ -74,7 +74,7 @@ def call(*args)
       end
     end
 
-    private # rubocop:disable Lint/UselessAccessModifier
+    private
 
     # NOTE: currently only supporting the few function signatures that we need for Natalie's REPL
     # In the future, Natalie will have macros that will allow this to be generated at compile time.

lib/fileutils.rb

@@ -21,7 +21,7 @@ def self.mkdir_p(path, mode: nil)
     mkdir =
       lambda do |dir, *args|
         Dir.mkdir(dir, *args)
-      rescue StandardError # rubocop:disable Style/RescueStandardError
+      rescue StandardError
         raise unless File.directory?(dir)
       end
 

lib/json.rb

@@ -136,10 +136,10 @@ def next_token
       case (c = current_char)
       when 't'
         raise ParserError, "unknown literal: #{c}" unless advance(4) == 'true'
-        :true # rubocop:disable Lint/BooleanSymbol
+        :true
       when 'f'
         raise ParserError, "unknown literal: #{c}" unless advance(5) == 'false'
-        :false # rubocop:disable Lint/BooleanSymbol
+        :false
       when 'n'
         raise ParserError, "unknown literal: #{c}" unless advance(4) == 'null'
         :null
@@ -261,9 +261,9 @@ def parse
 
     def parse_sequence(token)
       case token
-      when :true # rubocop:disable Lint/BooleanSymbol
+      when :true
         true
-      when :false # rubocop:disable Lint/BooleanSymbol
+      when :false
         false
       when :null
         nil

lib/natalie/compiler/macro_expander.rb

@@ -186,11 +186,11 @@ def macro_eval(expr:, current_path:, locals:, **)
         end
       end
 
-      def macro_nat_ignore_require(expr:, current_path:) # rubocop:disable Lint/UnusedMethodArgument
+      def macro_nat_ignore_require(expr:, current_path:)
         Prism.false_node(location: nil) # Script has not been loaded
       end
 
-      def macro_nat_ignore_require_relative(expr:, current_path:) # rubocop:disable Lint/UnusedMethodArgument
+      def macro_nat_ignore_require_relative(expr:, current_path:)
         Prism.false_node(location: nil) # Script has not been loaded
       end
 

lib/natalie/compiler/pass1.rb

@@ -2510,7 +2510,7 @@ def transform_retry_node(*)
         [RetryInstruction.new(id: @retry_context.last)]
       end
 
-      def transform_return_node(node, used:) # rubocop:disable Lint/UnusedMethodArgument
+      def transform_return_node(node, used:)
         [transform_arguments_node_for_returnish(node.arguments, location: node.location), ReturnInstruction.new]
       end
 

lib/pathname.rb

@@ -99,10 +99,10 @@ def +(other)
 end
 
 module Kernel
-  private def Pathname(arg) # rubocop:disable Naming/MethodName
+  private def Pathname(arg)
     Pathname.new(arg)
   end
-  def self.Pathname(arg) # rubocop:disable Naming/MethodName
+  def self.Pathname(arg)
     Pathname.new(arg)
   end
 end

lib/strscan.rb

@@ -181,7 +181,7 @@ def scan_full(pattern, advance_pointer_p, return_string_p)
 
   alias search_full scan_full
 
-  def get_byte # rubocop:disable Naming/AccessorMethodName
+  def get_byte
     @matched = scan(/./)
   end
 
@@ -291,7 +291,7 @@ def clear
     terminate
   end
 
-  def self.must_C_version # rubocop:disable Naming/MethodName
+  def self.must_C_version
     self
   end
 end

spec/language/block_spec.rb

@@ -751,7 +751,7 @@ def obj.to_ary; raise "Exception raised in #to_ary" end
     end
 
     it "accepts unnamed arguments" do
-      lambda { |_,_| }.should be_an_instance_of(Proc) # rubocop:disable Style/Lambda
+      lambda { |_,_| }.should be_an_instance_of(Proc)
       -> _,_ {}.should be_an_instance_of(Proc)
       Proc.new { |_,_| }.should be_an_instance_of(Proc)
     end

spec/language/ensure_spec.rb

@@ -347,7 +347,7 @@ def foo
         begin
           raise "oops"
         ensure
-          return caller(0, 2) # rubocop:disable Lint/EnsureReturn
+          return caller(0, 2)
         end
       end
       line = __LINE__

spec/language/execution_spec.rb

@@ -40,7 +40,7 @@
 
     2.times do
       runner.instance_exec do
-        `test #{:command}` # rubocop:disable Lint/LiteralInInterpolation
+        `test #{:command}`
       end
     end
 
@@ -88,7 +88,7 @@
 
     2.times do
       runner.instance_exec do
-        %x{test #{:command}} # rubocop:disable Lint/LiteralInInterpolation
+        %x{test #{:command}}
       end
     end
 

spec/language/string_spec.rb

@@ -254,7 +254,7 @@ def long_string_literals
 
 describe "Ruby String interpolation" do
   it "permits an empty expression" do
-    s = "#{}" # rubocop:disable Lint/EmptyInterpolation
+    s = "#{}"
     s.should.empty?
     s.should_not.frozen?
   end

test/encodings/eucjp_tables.rb

@@ -9,7 +9,7 @@
 }.freeze
 
 TABLES.each do |table_name, url|
-  lines = URI.open(url).readlines(chomp: true) # rubocop:disable Security/Open
+  lines = URI.open(url).readlines(chomp: true)
   index = lines.grep_v(/^#|^\s*$/).map(&:split).each_with_object({}) { |(idx, value, *), hash| hash[idx.to_i] = value }
 
   print "static const long #{table_name}[] = {"

test/natalie/argument_test.rb

@@ -77,7 +77,7 @@ def baz(a)
 describe 'underscore args' do
   def underscore_arguments(_, _)
     _
-  end # rubocop:disable Lint/UnderscorePrefixedVariableName
+  end
 
   it 'does not overwrite the first underscore' do
     underscore_arguments(1, 2).should == 1

test/natalie/method_visibility_test.rb

@@ -10,7 +10,7 @@ def public_foo_calling_private_foo
   end
 
   def public_foo_calling_private_foo_with_self
-    self.private_foo # rubocop:disable Style/RedundantSelf
+    self.private_foo
   end
 
   def public_foo_calling_protected_foo

test/natalie/require_test.rb

@@ -28,7 +28,7 @@
 # this is here to test that order of requires goes top-to-bottom
 class Foo1Child < Foo1
 end
-require 'require/simple' # rubocop:disable Lint/DuplicateRequire
+require 'require/simple'
 
 # having this top-level variable named the same as the one in simple.rb
 # should not cause a compilation error