[Bug]: DSWx-HLS Integration test script reports passing when first test case fails

[RKuttruff]

Checked for duplicates

Yes - I've already checked

Describe the bug

When running the DSWx-HLS int test script, two executions are ran l30_greenland and s30_louisiana

In the event that l30_greenland fails but s30_louisiana passes, the overall test reports a pass

I suspect it's due to this block:

opera-sds-pge/.ci/scripts/dswx_hls/test_int_dswx_hls.sh

Lines 111 to 117 in 0cbe9d9

	if [ $docker_exit_status -ne 0 ]; then
	echo "docker exit indicates failure: ${docker_exit_status}"
	overall_status=1
	else
	# Retrieve the return code written to disk by the comparison script
	overall_status=$(cat "$output_dir/compare_dswx_hls_products.rc")
	fi

overwriting the exit code from the previous test case iteration.

What did you expect?

I expected the overall test to report failure if either test case fails.

Reproducible steps

On opera-dev-pge, build a PROTEUS SAS image off of commit e22fc8a695c274d25f0281b019d3fa2b265a816fe22fc8a695c274d25f0281b019d3fa2b265a816f, build the DSWx-HLS PGE on top of that. Run the int test, then modify the int script to only run l30_greenland and run the int test again.

Environment

opera-dev-pge

[collinss-jpl]

Good catch. If that section of code is indeed the culprit, then we likely have the same issue in the DISP-S1 int test script that will need to be fixed as well:

opera-sds-pge/.ci/scripts/disp_s1/test_int_disp_s1.sh

Lines 127 to 133 in 0cbe9d9

	if [ $docker_exit_status -ne 0 ]; then
	echo "docker exit indicates failure: ${docker_exit_status}"
	overall_status=1
	else
	# Retrieve the return code written to disk by the comparison script
	overall_status=$(cat "$output_dir/compare_disp_s1_products.rc")
	fi