Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-injection-token): add injector to create injection token #78

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

nartc
Copy link
Collaborator

@nartc nartc commented Sep 23, 2023

No description provided.

@nartc nartc self-assigned this Sep 23, 2023
@nartc nartc added the enhancement New feature or request label Sep 23, 2023
@nartc nartc enabled auto-merge (squash) September 23, 2023 02:22
@nx-cloud
Copy link

nx-cloud bot commented Sep 23, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1b6cd77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

"name": "16-8-2-update-swcrc"
}
]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't need to be commited, doest it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, After the migrations have been run, nx no longer needs this file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it needs to be removed!

Copy link
Collaborator

@eneajaho eneajaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nartc nartc merged commit b3ebe4b into main Sep 23, 2023
@nartc nartc deleted the fix/add-injector-to-create-injection-token branch September 23, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants