Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repeat-pipe): initial version #320

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

Dafnik
Copy link
Contributor

@Dafnik Dafnik commented Apr 8, 2024

Adds the repeat pipe as described in #313

Copy link

nx-cloud bot commented Apr 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 302e549. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx-cloud record -- nx format:check

Sent with 💌 from NxCloud.

Copy link
Collaborator

@eneajaho eneajaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good! Thanks for the contribution 🎉!

@eneajaho
Copy link
Collaborator

eneajaho commented Apr 9, 2024

Can we add a note in the Repeat directive to let the devs know that a repeat pipe also exists?

This way, if they want to use the new control flow, they may want to use the repeat pipe instead of the directive.

@eneajaho eneajaho requested a review from nartc April 9, 2024 16:15
@Dafnik Dafnik force-pushed the feature/repeat-pipe branch from 5e0bf22 to 302e549 Compare April 9, 2024 16:59
@eneajaho eneajaho merged commit 70abad3 into ngxtension:main Apr 9, 2024
1 of 2 checks passed
@Dafnik Dafnik deleted the feature/repeat-pipe branch April 9, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants