Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(if-validator): exclude individual validators from composition to allow presence checks #273

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

rlmestre
Copy link
Contributor

Closes #262

Copy link

nx-cloud bot commented Feb 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 732329f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@eneajaho eneajaho requested a review from nartc February 13, 2024 16:38
@eneajaho
Copy link
Collaborator

Hello @rlmestre
Can you rebase this, and then I think we can merge 🙌

@rlmestre rlmestre force-pushed the fix/if-validator-composition branch from 18899df to 980c6e3 Compare March 24, 2024 00:09
@rlmestre
Copy link
Contributor Author

Done 🙂 thanks @eneajaho !

@eneajaho eneajaho force-pushed the fix/if-validator-composition branch from 980c6e3 to 732329f Compare March 24, 2024 21:45
@eneajaho eneajaho enabled auto-merge (squash) March 24, 2024 21:45
@eneajaho eneajaho removed the request for review from nartc March 24, 2024 21:45
@eneajaho eneajaho merged commit 92a614c into ngxtension:main Mar 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ifValidator / ifAsyncValidator
2 participants