fix(convert-signal-inputs): handle input name overlap in template

[joshuamorony]

I used the signal inputs generator on a big project recently and ran into trouble with cases like this:

<test [normalInput]="normalInput" />
<test-normalInput />
<normalInput />
<another-component something="blah-normalInput" />

In cases where:

• A child component input had the same name as a parent component input
• The name of an input was used as part of a tag name
• The name of an input was used within a property value

The template was being updated incorrectly, e.g:

<test [normalInput()]="normalInput()" />
<test-normalInput() />
<normalInput() />
<another-component something="blah-normalInput()" />

NOTE: I noticed there where two different regexes being used for the template based on whether it was a templateUrl or inline. One was simpler and I assume was mistaking left un-updated whilst the other one had been updated to something more complex. I have updated both to use the same updated regex now, but wanted to make a note in case something intentional was happening here

This updates the RegExp to handle the cases I mentioned, break down from ChatGPT who gets credit for writing the actual regex:

• (?<![\w-]): Negative lookbehind to ensure ${convertedInput} is not immediately preceded by any word character or hyphen.
• \b${convertedInput}\b: Matches ${convertedInput} as a whole word.
• (?!\]): Negative lookahead to ensure ${convertedInput} is not immediately followed by ].
• (?!>): Negative lookahead to ensure ${convertedInput} is not immediately followed by >.
• (?![\w-]): Negative lookahead to ensure ${convertedInput} is not immediately followed by any word character or hyphen.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 64d51e1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --target=lint --parallel=3

✅ Successfully ran 2 targets

• nx affected --target=build --parallel=3 --exclude=docs
• nx affected --target=test --parallel=3 --ci --code-coverage

---

Sent with 💌 from NxCloud.