fix(signal-slice): prevent early inference in selector typing #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #213
Since the
selectors
are passed the entireSignalSlice
it will infer all of the types for actionSources/actionEffects etc when the selectors config is passed in (at which time those other configurations have not been supplied yet).I've made a typing change so that rather than being passed the entire
SignalSlice
theselectors
and others are only passed the subset of types that they actually need, e.gSelectorsState
andEffectsState
: