-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signal-slice): Do not allow optional properties in signalSlice #177
fix(signal-slice): Do not allow optional properties in signalSlice #177
Conversation
Thanks for this @palexcast - I'm happy with the change, and I don't know how else it would be fixed anyway (although @nartc has dealt with most of the tricker typing situations for signalSlice so he might have thoughts). I think we can just add a brief note about this to the docs under Basic Usage to explain that it is not allowed (we probably don't need to get into the specifics right away). |
@all-contributors please add @palexcast for code |
I've put up a pull request to add @palexcast! 🎉 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 704107e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following target is in progress
✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
LGTM. Can you add some comment to the ts-expect-error directive? |
Of course, done 👍 |
Optional properties in the initial state pose an issue with selectors, this PR forces a user to set it as undefined instead.
With
?:
With
| undefined
Issue explaining in detail: #176