Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signal-slice): Do not allow optional properties in signalSlice #177

Merged

Conversation

palexcast
Copy link
Contributor

Optional properties in the initial state pose an issue with selectors, this PR forces a user to set it as undefined instead.

With ?:

image

With | undefined

image

Issue explaining in detail: #176

@joshuamorony
Copy link
Contributor

Thanks for this @palexcast - I'm happy with the change, and I don't know how else it would be fixed anyway (although @nartc has dealt with most of the tricker typing situations for signalSlice so he might have thoughts). I think we can just add a brief note about this to the docs under Basic Usage to explain that it is not allowed (we probably don't need to get into the specifics right away).

@nartc
Copy link
Collaborator

nartc commented Nov 30, 2023

@all-contributors please add @palexcast for code

Copy link
Contributor

@nartc

I've put up a pull request to add @palexcast! 🎉

Copy link

nx-cloud bot commented Nov 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 704107e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following target is in progress

🟥 Failed Commands
nx affected --target=test --parallel=3 --ci --code-coverage
✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@nartc
Copy link
Collaborator

nartc commented Nov 30, 2023

LGTM. Can you add some comment to the ts-expect-error directive?

@palexcast
Copy link
Contributor Author

LGTM. Can you add some comment to the ts-expect-error directive?

Of course, done 👍

@nartc nartc merged commit 84ccf3c into ngxtension:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants