Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map-skip-undefined): add mapSkipUndefined + filterUndefined operator #113

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

dmorosinotto
Copy link
Contributor

This PR substitute #101 to add mapSkipUndefined and filterUndefined instead of old mapFilter proposed in #34
I also added simplified tests using toArray() as suggested by @tomalaforge + docs for both operators.
Hope this can be accepted.

@nx-cloud
Copy link

nx-cloud bot commented Oct 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 453f250. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@dmorosinotto
Copy link
Contributor Author

@nartc I don't get why CI is failing, the error is on code outside my commit, and before redoing all the work I synced my main branch with yours and then created the new branch to easily merge (fast-forward) my new PR at the end...!?

dmorosinotto referenced this pull request Oct 14, 2023
feat: added inject-is-intersecting
@eneajaho
Copy link
Collaborator

@nartc lets merge this first and then #115

@nartc nartc merged commit 1755b74 into ngxtension:main Oct 14, 2023
@dmorosinotto dmorosinotto deleted the feature/map-skip-undefined branch October 15, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants