fix(convert-signal-inputs): remove unnecessary undefined (#280)

ngxtension · Feb 15, 2024 · 0356be0 · 0356be0
1 parent e11f2cd
commit 0356be0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/libs/plugin/src/generators/convert-signal-inputs/__snapshots__/generator.spec.ts.snap b/libs/plugin/src/generators/convert-signal-inputs/__snapshots__/generator.spec.ts.snap
@@ -38,8 +38,8 @@ import { input } from "@angular/core";
 export class MyCmp {
   inputWithoutType = input();
   normalInput = input('');
-  withoutDefault = input<string | undefined>();
-  withoutDefaultUnion = input<string | undefined>();
+  withoutDefault = input<string>();
+  withoutDefaultUnion = input<string>();
   withDefaultAlias = input(123, { alias: 'defaultAlias' });
   withoutDefaultAlias = input<number | undefined>(undefined, { alias: 'noDefaultAlias' });
   justAStringAlias = input('', { alias: 'stringAlias' });
@@ -146,8 +146,8 @@ import { input } from "@angular/core";
 export class MyCmp {
   inputWithoutType = input();
   normalInput = input('');
-  withoutDefault = input<string | undefined>();
-  withoutDefaultUnion = input<string | undefined>();
+  withoutDefault = input<string>();
+  withoutDefaultUnion = input<string>();
   withDefaultAlias = input(123, { alias: 'defaultAlias' });
   withoutDefaultAlias = input<number | undefined>(undefined, { alias: 'noDefaultAlias' });
   justAStringAlias = input('', { alias: 'stringAlias' });

diff --git a/libs/plugin/src/generators/convert-signal-inputs/generator.ts b/libs/plugin/src/generators/convert-signal-inputs/generator.ts
@@ -96,14 +96,15 @@ function getSignalInputInitializer(
 				types.push(transformType, ',');
 			}
 
-			types.push(typeNode);
-
 			if (
-				!isRequired &&
-				!typeNode.includes('undefined') &&
-				(property.hasQuestionToken() || !propertyInitializer)
+				propertyInitializer?.getType() === undefined &&
+				Node.isObjectLiteralExpression(decoratorArg) &&
+				property.hasQuestionToken()
 			) {
+				types.push(typeNode);
 				types.push('| undefined');
+			} else {
+				types.push(typeNode.replace('| undefined', ''));
 			}
 
 			writer.write(types.concat('>').join(''));