Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python wrapper to use minimal RF24 constructor #158

Closed
TMRh20 opened this issue Nov 6, 2015 · 4 comments
Closed

Update python wrapper to use minimal RF24 constructor #158

TMRh20 opened this issue Nov 6, 2015 · 4 comments
Assignees

Comments

@TMRh20
Copy link
Member

TMRh20 commented Nov 6, 2015

Reminder to update python wrapper to use minimal RF24 constructor, for use/compatibility with both BCM and SPIDEV usage.

@TMRh20 TMRh20 self-assigned this Nov 6, 2015
@martin-mat
Copy link
Collaborator

@TMRh20, any plan with this? I guess best would be to check whether RF24 on the system is compiled with BCM support (is that evident from RF24.h?) and depending on that include/exclude BCM-related stuff in the python wrapper?

@TMRh20
Copy link
Member Author

TMRh20 commented Nov 13, 2015

Heh, no real plan, just a rough idea. My thoughts initially revolved around removing all the BCM specific stuff from the C++ & python examples, and fixing all the documentation to refer to the standard linux constructor ( like RF24 (22,0) ) while still actually supporting the BCM initialization, just that it would become a mostly undocumented option.

This would mainly be to allow some transition time and prevent more confusion around the constructor. Eventually, I think it's probably a good idea to remove the BCM specific stuff altogether, and stick with GPIO + SPI-BUS numbers for Linux devices.

@martin-mat
Copy link
Collaborator

Python wrapper now exposes BCM specific stuff only if it's in C++ RF24, 95926b2

@martin-mat
Copy link
Collaborator

From my point of view it's resolved, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants