possible problem with double qouted data after a named placeholder

[danieljuhl]

I've tried to create the most minimal case, where this happens (used with node-mysql2):

conn.execute('SELECT * FROM items WHERE id = :id AND deleted = "0000-00-00 00:00:00";', { id: Number(id) }) fails, but conn.execute('SELECT * FROM items WHERE deleted = "0000-00-00 00:00:00" AND id = :id;', { id: Number(id) }) works fine.

For some reason the first one is converted to: SELECT * FROM items WHERE id = ?";

[sidorares]

what's the result of resolving named placeholders? can you print unnamed at https://github.com/sidorares/node-mysql2/blob/master/lib/connection.js#L405 ?

[sidorares]

looks like a bug in named_placeholders compiler ( might be caused by "0000-00-00 00:00:00" )

[sidorares]

it's ok if I delete ":" from date, so probably bug in parser in "in quote" state. Might be also the case for @mscdex node-mariasql

[danieljuhl]

Seems very likely... but it depends on, whether it is placed before or after the other named placeholders (also for more complex queries - as long as the fixed date is before any named placeholders, there is no problem)

[danieljuhl]

@sidorares you still want unnamed?

[sidorares]

no, no need, run it locally myself

[danieljuhl]

Perfect - let me know, if there is anything I can do.

As said, the workaround is simply to place the date string part prior to any named placeholders, so everything works right now, but we should try to find a way to handle this in the module.

[sidorares]

it's definitely a bug, I'll try to fix it