Question? Bug? About Multihashing func

[Schwartz10]

Hi there! I'm working on a large project, where multihashing gets depended on. I'm not sure if this is a bug isolated in this package, or if it's introduced from some outer-dep (I don't expect this to be true but in this case, its ipld-dag-cbor@0.17.0).

The Multihashing.digest func, in the code comments, is supposed to return a Uint8Array. yet when I log digest instanceof Uint8Array, it returns false. This causes the following multihash.encode call to throw the error: digest should be a Uint8Array

The alg param in this instance is 0x18 or shake-128

For more clarity:

async function Multihashing (buf, alg, length) {
  console.log('buff instance of Uint8Array? ', buf instanceof Uint8Array) // => logs true
  const digest = await Multihashing.digest(buf, alg, length)
  console.log('digest instance of Uint8Array?', digest instanceof Uint8Array) // => logs false
  return multihash.encode(digest, alg, length)
}

This is obviously not going to play nicely with this line

[Schwartz10]

Turns out this is a problem with jest most likely - jestjs/jest#4422

The fix was to use https://www.npmjs.com/package/jest-environment-uint8array as the jest test environment. Thanks to @oed for the tip on this one.