feat: add convert subpath export #246
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @achingbrain |
achingbrain
changed the title
achingbrain
approved these changes
Jun 8, 2022
|
when you get a chance, i'd love to have this merged/released so we put this into use |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
## [10.2.0](v10.1.8...v10.2.0) (2022-06-09) ### Features * add convert subpath export ([#246](#246)) ([c69283b](c69283b))
|
🎉 This PR is included in version 10.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to convert multiaddr segments to / from bytes in a library that can create multiaddrs.
Creating a full multiaddr wouldn't make sense, nor would reimplementing the conversion logic if it already exists in this library.
Before the ESM version of this library I used multiaddrs/src/convert directly.
See usage of
muConverthere https://github.com/ChainSafe/discv5/blob/master/src/enr/enr.ts