Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Chinese drawer translation issue #13705

Closed
rockmandash opened this issue Nov 27, 2018 · 4 comments
Closed

[docs] Chinese drawer translation issue #13705

rockmandash opened this issue Nov 27, 2018 · 4 comments
Assignees
@oliviertassinari
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation

Comments

@rockmandash
Copy link

rockmandash commented Nov 27, 2018 •
edited
Loading

Site is down.
clean cache is not helping.
It says, unexpected....
@mbrookes
Copy link
Member

Looks fine here...

https://downforeveryoneorjustme.com/material-ui.com

(http://isup.me)

@rockmandash
Copy link
Author

@mbrookes I checked, only drawers demo page down

@eps1lon
Copy link
Member

eps1lon commented Nov 27, 2018

It's with the chinese translation.

@mbrookes We should check if the file actually exist in https://github.com/mui-org/material-ui/blob/master/pages/css-in-js/advanced.js#L10 and render some 404 page instead. Since we currently don't define any error boundaries a missing translation is currently not distinguishable from errors in the demo or our docs components.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 27, 2018
@oliviertassinari oliviertassinari self-assigned this Nov 27, 2018
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Nov 27, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 28, 2018 •
edited
Loading

I'm investigating this issue, so far, it's a problem in https://github.com/ryanseddon/react-frame-component.

@joshwooding joshwooding mentioned this issue Nov 28, 2018
Closed
@oliviertassinari oliviertassinari changed the title Site is down [docs] Chinese drawer translation issue Nov 29, 2018
@oliviertassinari oliviertassinari mentioned this issue Nov 30, 2018
Merged
@oliviertassinari oliviertassinari mentioned this issue Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mbrookes @oliviertassinari @rockmandash @eps1lon