-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DatePicker] Update to match the specification (desktop) #1648
Comments
oh goodness, really components have different sizes for desktop. Looks like all of our sizes are for mobile. Thanks for catching it! |
Sorry, I should have mentioned that mobile and desktop should have different dimensions. Thanks for inlining the screeshot from the specification with the actual dimensions. |
Regarding the media query logic. I would be eager to try a logic based on touch vs click support as the primary pointer device (instead of the screen width). It's definitely related to #1653. |
@dmtrKovalenko Regarding your concern about the size. The core components try to follow the size of the specification, as much as possible, but we have divergences, especially when the specification isn't consistent or dropping 1px simplifies the CSS. I think that we can benchmark with a couple of frequently used date pickers, to get a sense of where we are on the spectrum (sorted from too small to too large):
Site note, we add vertical spacing on the rows and horizontal spacing on the columns. I think that we should aim for a single place (single element/selector) to handle CSS spacing, to make overrides simpler. |
Environment
Steps to reproduce
https://next.material-ui-pickers.dev/demo/datepicker#basic-usage
Actual behavior
Expected behavior
#7001f3
to get an idea of the issue. I propose this diff:before
after
baseline
Looking again, 0.8 isn't enough. Maybe 0.85 or 0.9.
The text was updated successfully, but these errors were encountered: