-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snackbar] Improve consecutive demos #20721
Merged
oliviertassinari
merged 1 commit into
mui:master
from
logicalmoody:async-snackbar-example
Apr 23, 2020
Merged
[Snackbar] Improve consecutive demos #20721
oliviertassinari
merged 1 commit into
mui:master
from
logicalmoody:async-snackbar-example
Apr 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: d48def3...ff11358 Details of page changes
|
oliviertassinari
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds fair
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: snackbar
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋🏻
I came across an issue with the consecutive Snackbar demo while working off of this code for a project at work. I implemented a Snackbar and while working on this demo, I ran into async issues between setting the
open
state and adding/removing snacks from thequeueRef
in quick succession (like after API calls, for example).I solved the issue in my project and figured I would also contribute what I learned back to the repository to help anyone else who runs into this issue. I believe this refactor is more "React-y" and does not stray from the originally intended functionality of the demo.
Changelog:
useEffect()
to make changes to the current message, ensuring that a race condition between thequeueRef
andsetOpen()
doesn't occur.useEffect()
.snackPack
state on click, and move logic to theuseEffect()
.