-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Fix focus after click #20651
[Slider] Fix focus after click #20651
Conversation
Details of bundle changes.Comparing: 310fcb1...82a05e6 Details of page changes
|
b12da99
to
54df83b
Compare
54df83b
to
82a05e6
Compare
@davidcalhoun I have updated your test to be failing without the patch. I believe we were already testing that the component responds to arrow changes. If we don't, it could be an interesting follow-up pull request to increase test coverage. For now, let's focus on the regression. Thank you :D. |
@oliviertassinari No worries, thanks for the heads up! The test I added was failing on my machine without the patch, though maybe that was some side effect that wasn't testing the root issue. In any case, the test you added was cleaner and probably tests the root issue better! |
This fixes a regression with the
Slider
variant withmarks
that was introduced in4.9.10
, which broke keyboard interaction. This fixes that and adds a new test to check for this behavior. Original bug report:Closes #20645