stricter luacheck

Author: BuckarooBanzay

.luacheckrc

@@ -1,7 +1,3 @@
-unused_args = false
-allow_defined_top = true
-
-ignore = {"512"}
 
 globals = {
 	"jumpdrive",

common.lua

@@ -54,13 +54,15 @@ function jumpdrive.get_radius(pos)
 end
 
 -- calculates the power requirements for a jump
-function jumpdrive.calculate_power(radius, distance, sourcePos, targetPos)
+-- params: radius, distance, sourcePos, targetPos
+function jumpdrive.calculate_power(radius, distance)
 	return 10 * distance * radius
 end
 
 
 -- preflight check, for overriding
-function jumpdrive.preflight_check(source, destination, radius, playername)
+-- params: source, destination, radius, playername
+function jumpdrive.preflight_check()
 	return { success=true }
 end
 

compat/compat.lua

@@ -79,7 +79,7 @@ jumpdrive.commit_node_compat = function()
 end
 
 
-jumpdrive.target_region_compat = function(source_pos1, source_pos2, target_pos1, target_pos2, delta_vector)
+jumpdrive.target_region_compat = function(_, _, target_pos1, target_pos2, delta_vector)
 	-- sync compat functions
 
 	if has_beds_mod then

compat/elevator.lua

@@ -2,7 +2,7 @@
 local nodedef = minetest.registered_nodes["elevator:motor"]
 
 minetest.override_item("elevator:motor", {
-	on_movenode = function(from_pos, to_pos)
+	on_movenode = function(_, to_pos)
 		minetest.log("action", "[jumpdrive] Restoring elevator @ " .. to_pos.x .. "/" .. to_pos.y .. "/" .. to_pos.z)
 		nodedef.after_place_node(to_pos, nil, nil)
 	end

compat/technic_networks.lua

@@ -39,7 +39,7 @@ if technic.remove_network and technic.pos2network and technic.machines then
 		cable_groups[("technic_%s_cable"):format(tier:lower())] = 1
 	end
 
-	local function is_network_node(name, def)
+	local function is_network_node(_, def)
 		if not def.groups then return end
 		for group,_ in pairs(cable_groups) do
 			if def.groups[group] then return true end

compat/travelnet.lua

@@ -5,7 +5,7 @@ minetest.register_on_mods_loaded(function()
 	for node, def in pairs(minetest.registered_nodes) do
 		if def.groups and def.groups.travelnet == 1 then
 			minetest.override_item(node, {
-				on_movenode = function(from_pos, to_pos)
+				on_movenode = function(_, to_pos)
 					local meta = minetest.get_meta(to_pos);
 					minetest.log("action", "[jumpdrive] Restoring travelnet @ " .. to_pos.x .. "/" .. to_pos.y .. "/" .. to_pos.z)
 

engine.lua

@@ -7,12 +7,12 @@ minetest.register_node("jumpdrive:engine", {
 	tiles = {"jumpdrive.png"},
 
 	tube = {
-		insert_object = function(pos, node, stack, direction)
+		insert_object = function(pos, _, stack)
 			local meta = minetest.get_meta(pos)
 			local inv = meta:get_inventory()
 			return inv:add_item("main", stack)
 		end,
-		can_insert = function(pos, node, stack, direction)
+		can_insert = function(pos, _, stack)
 			local meta = minetest.get_meta(pos)
 			local inv = meta:get_inventory()
 			stack = stack:peek_item(1)
@@ -81,7 +81,7 @@ minetest.register_node("jumpdrive:engine", {
 			not minetest.is_protected(pos, name)
 	end,
 
-	on_timer = function(pos, elapsed)
+	on_timer = function(pos)
 		local meta = minetest.get_meta(pos)
 
 		local store = meta:get_int("powerstorage")
@@ -123,7 +123,7 @@ minetest.register_node("jumpdrive:engine", {
 
 	technic_run = jumpdrive.technic_run,
 
-	on_receive_fields = function(pos, formname, fields, sender)
+	on_receive_fields = function(pos, _, fields, sender)
 
 		local meta = minetest.get_meta(pos);
 		jumpdrive.migrate_engine_meta(pos, meta)
@@ -214,7 +214,7 @@ minetest.register_node("jumpdrive:engine", {
 		return count
 	end,
 
-	allow_metadata_inventory_take = function(pos, listname, index, stack, player)
+	allow_metadata_inventory_take = function(pos, _, _, stack, player)
 		if (not player)
 			or (not player:is_player())
 			or minetest.is_protected(pos, player:get_player_name())
@@ -223,7 +223,7 @@ minetest.register_node("jumpdrive:engine", {
 		return stack:get_count()
 	end,
 
-	allow_metadata_inventory_put = function(pos, listname, index, stack, player)
+	allow_metadata_inventory_put = function(pos, _, _, stack, player)
 		if (not player)
 			or (not player:is_player())
 			or minetest.is_protected(pos, player:get_player_name())
@@ -251,7 +251,7 @@ minetest.register_node("jumpdrive:engine", {
 		end
 	end,
 
-	on_punch = function(pos, node, player)
+	on_punch = function(pos, _, player)
 		if not has_vizlib then
 			-- no visualization lib
 			return

fleet/fleet_controller.lua

@@ -56,7 +56,7 @@ minetest.register_node("jumpdrive:fleet_controller", {
 		return inv:is_empty("main") and not minetest.is_protected(pos, name)
 	end,
 
-	on_receive_fields = function(pos, formname, fields, sender)
+	on_receive_fields = function(pos, _, fields, sender)
 
 		local meta = minetest.get_meta(pos);
 
@@ -174,7 +174,7 @@ minetest.register_node("jumpdrive:fleet_controller", {
 
 	end,
 
-	on_timer = function(pos, elapsed)
+	on_timer = function(pos)
 		local meta = minetest.get_meta(pos)
 		local jump_index = meta:get_int("jump_index")
 		local jump_list = minetest.deserialize( meta:get_string("jump_list") )

fleet/fleet_digiline.lua

@@ -134,7 +134,7 @@ jumpdrive.fleet.digiline_async_simulate = function(pos, channel, owner, engines)
 	minetest.after(1, async_check)
 end
 
-jumpdrive.fleet.digiline_async_jump = function(pos, target_pos, channel, owner, engines)
+jumpdrive.fleet.digiline_async_jump = function(pos, target_pos, channel, _, engines)
 	local t0 = minetest.get_us_time()
 	local meta = minetest.get_meta(pos)
 	local all_success = false

fleet/fleet_formspec.lua

@@ -1,5 +1,5 @@
 
-jumpdrive.fleet.update_formspec = function(meta, pos)
+jumpdrive.fleet.update_formspec = function(meta)
 
 	local button_line =
 		"button_exit[0,1.5;2,1;jump;Jump]" ..

formspec.lua

@@ -5,7 +5,7 @@ if has_technic then
 	inv_offset = 1.25
 end
 
-jumpdrive.update_formspec = function(meta, pos)
+jumpdrive.update_formspec = function(meta)
 	local formspec =
 		"size[8," .. 9.3+inv_offset .. ";]" ..
 

infotext.lua

@@ -1,6 +1,6 @@
 local has_technic = minetest.get_modpath("technic")
 
-jumpdrive.update_infotext = function(meta, pos)
+jumpdrive.update_infotext = function(meta)
 	local store = meta:get_int("powerstorage")
 	local max_store = meta:get_int("max_powerstorage")
 

integration_test.lua

@@ -45,7 +45,7 @@ local function execute_mapgen(callback)
 end
 
 local function execute_test(callback)
-	execute_mapgen(function(blockpos, action, calls_remaining)
+	execute_mapgen(function(blockpos, _, calls_remaining)
 		minetest.log("action", "Emerged: " .. minetest.pos_to_string(blockpos))
 		if calls_remaining > 0 then
 			return

jump.lua

@@ -47,7 +47,8 @@ jumpdrive.simulate_jump = function(pos, player, show_marker)
 	local success = true
 
 	local blacklisted_pos_list = minetest.find_nodes_in_area(source_pos1, source_pos2, jumpdrive.blacklist)
-	for _, nodepos in ipairs(blacklisted_pos_list) do
+	local _, nodepos = next(blacklisted_pos_list)
+	if nodepos then
 		return false, "Can't jump node @ " .. minetest.pos_to_string(nodepos)
 	end
 

mapgen.lua

@@ -16,7 +16,7 @@ jumpdrive.mapgen.reset = function()
 end
 
 -- update last mapgen event time
-minetest.register_on_generated(function(minp, maxp, seed)
+minetest.register_on_generated(function(minp, maxp)
 	table.insert(events, {
 		minp = minp,
 		maxp = maxp,

technic_run.lua

@@ -1,5 +1,5 @@
 
-jumpdrive.technic_run = function(pos, node)
+jumpdrive.technic_run = function(pos)
 	local meta = minetest.get_meta(pos)
 	jumpdrive.migrate_engine_meta(pos, meta)