Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with dialog in lazy loaded components #997

Closed
JSMike opened this issue Jun 6, 2017 · 2 comments
Closed

Issue with dialog in lazy loaded components #997

JSMike opened this issue Jun 6, 2017 · 2 comments

Comments

@JSMike
Copy link
Contributor

JSMike commented Jun 6, 2017

Hello 😄 ,

MdlDialogModule imports the MdlDialogOutletModule with forRoot. This causes issues when a lazy loaded component contains dialogs, when using a <dialog-outlet> on a parent that isn't lazy loaded, the outlet cannot be found. I would suggest adding the MdlDialogOutletService directly to the to the MdlDialogModule's forRoot function instead of calling forRoot on the MdlDialogOutletModule import. Unless there's a better pattern to follow.

Note: The error is currently resolved by importing MdlDialogModule with .forRoot() on both the main app module and the lazily loaded module, but this feels like an anti-pattern.

@mseemann
Copy link
Owner

mseemann commented Jun 8, 2017

hi. need to think about it...

@unixxxx
Copy link

unixxxx commented Aug 15, 2017

any news about this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants