Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Allow multivalue for Config attibutes #761

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

ChrisHubinger
Copy link
Contributor

#548

Implemented & documented the same multivalue behavior for keycloak_custom_user_federation resource as it's done in keycloak_user.

* FEAT: Allow multivalue for Config attibutes
* Documentation for multivalue behaviour
@ChrisHubinger
Copy link
Contributor Author

Unfortunately, I could not get the local test setup running with the custom user storage SPI.

The docker-compose mapps the built SPI to the /opt/jboss/keycloak/standalone/deployments/ folder, although it is already using the quarkus version of keycloak.

Just setting the correct path did not work as it throws the following build error during keycloak start up:

terraform-provider-keycloak-keycloak-1  | Updating the configuration and installing your custom providers, if any. Please wait.
terraform-provider-keycloak-keycloak-1  | The DelayedHandler was closed before any children handlers were configured. Messages will be written to stderr.
terraform-provider-keycloak-keycloak-1  | 2022-11-04 11:39:06,327 DEBUG [org.jboss.logging] (main) Logging Provider: org.jboss.logging.JBossLogManagerProvider

[..]
terraform-provider-keycloak-keycloak-1  | 2022-11-04 11:39:07,362 DEBUG [io.quarkus.deployment.QuarkusAugmentor] (main) Beginning Quarkus augmentation
terraform-provider-keycloak-keycloak-1  |
terraform-provider-keycloak-keycloak-1  | ERROR: Failed to run 'build' command.
terraform-provider-keycloak-keycloak-1  | ERROR: org.eclipse.microprofile.config.spi.ConfigSource: org.jboss.resteasy.microprofile.config.ServletConfigSource not a subtype
terraform-provider-keycloak-keycloak-1  | For more details run the same command passing the '--verbose' option. Also you can use '--help' to see the details about the usage of the particular command.
terraform-provider-keycloak-keycloak-1 exited with code 1

I'd be happy to wirte tests if I find a way to run them.

@mrparkers
Copy link
Contributor

Unfortunately, I could not get the local test setup running with the custom user storage SPI.

No problem, these tests don't run in CI anyways.

Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mrparkers mrparkers enabled auto-merge (squash) March 2, 2023 19:13
@mrparkers mrparkers disabled auto-merge March 2, 2023 19:13
@mrparkers mrparkers merged commit c9b2f8a into keycloak:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants