Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort masterkeys to try offline decrypt methods first #1121

Closed
wants to merge 1 commit into from
Closed

Sort masterkeys to try offline decrypt methods first #1121

wants to merge 1 commit into from

Conversation

bkreitch
Copy link
Contributor

@bkreitch bkreitch commented Sep 3, 2022 •
edited
Loading

This is to address #305. Sort master keys so PGP/age keys appear before the others and being used first.

@bkreitch bkreitch mentioned this pull request Sep 3, 2022
Open
@bkreitch bkreitch marked this pull request as ready for review September 4, 2022 16:31
@bkreitch
Copy link
Contributor Author

bkreitch commented Sep 8, 2022

@ajvb Hi, sorry to bother you, but could you maybe take a look please? Hopefully it's a quick win :)

@bkreitch bkreitch mentioned this pull request Sep 10, 2022
Merged
@hiddeco hiddeco added this to the v3.8.0 milestone Jul 3, 2023
@hiddeco
Copy link
Member

hiddeco commented Jul 3, 2023

This is a sensible change, I think. It would be great if you could rebase your work and sign-off your commit. Thanks! 🙇

@bkreitch bkreitch force-pushed the try-offline-methods-first branch from 6ae5db0 to 294bc66 Compare July 4, 2023 14:00
@bkreitch
Copy link
Contributor Author

bkreitch commented Jul 4, 2023

@hiddeco Ok, rebased and signed-off. Great to see that the project is back to life! 🎉

@hiddeco hiddeco modified the milestones: v3.8.0, v3.9.0 Jul 4, 2023
@hiddeco
Copy link
Member

hiddeco commented Jul 4, 2023

I have to check this against the history from the issue, which is why I moved it one milestone further.

But do know it’s on the (now active) backlog. 🍒

felixfontein
felixfontein approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

felixfontein
felixfontein reviewed Nov 5, 2023
View reviewed changes
@felixfontein
Copy link
Contributor

#305 (comment) might be preferable to this solution, since it is more flexible.

@bkreitch bkreitch force-pushed the try-offline-methods-first branch 3 times, most recently from 3caa7d6 to 2bb9d76 Compare November 6, 2023 07:19
@bkreitch
Sort masterkeys to try offline decrypt methods first
bcac5bd 
Signed-off-by: Boris Kreitchman <bkreitch@gmail.com>
@bkreitch bkreitch force-pushed the try-offline-methods-first branch from 2bb9d76 to bcac5bd Compare November 6, 2023 17:45
@bkreitch bkreitch mentioned this pull request Nov 8, 2023
Merged
@bkreitch
Copy link
Contributor Author

bkreitch commented Nov 8, 2023

#305 (comment) might be preferable to this solution, since it is more flexible.

@felixfontein Hi, I've opened #1345 which supports comma-separated --decryption-order to replace this PR.
(or I can push the new code into this PR if it's more convenient)

@bkreitch bkreitch closed this Dec 18, 2023
@bkreitch bkreitch deleted the try-offline-methods-first branch December 18, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bkreitch @hiddeco @felixfontein