Bug 1732306 - Part 2: Implement strong role mappings, r=Jamie

This revision implements mapping for the ARIA 1.2 'strong' role by adding a
markup mapping, a role definition, and platform mappings. This revision also
removes the expected failures in the wpt test suite and fixes other tests.

Differential Revision: https://phabricator.services.mozilla.com/D200131

Author: Nathan LaPre

accessible/base/ARIAMap.cpp

@@ -1183,6 +1183,16 @@ static const nsRoleMapEntry sWAIRoleMaps[] = {
     kGenericAccType,
     kNoReqStates
   },
+  { // strong
+    nsGkAtoms::strong,
+    roles::STRONG,
+    kUseMapRole,
+    eNoValue,
+    eNoAction,
+    eNoLiveAttr,
+    kGenericAccType,
+    kNoReqStates
+  },
   { // subscript
     nsGkAtoms::subscript,
     roles::SUBSCRIPT,

accessible/base/HTMLMarkupMap.h

@@ -348,6 +348,8 @@ MARKUPMAP(
     },
     0)
 
+MARKUPMAP(strong, New_HyperText, roles::STRONG)
+
 MARKUPMAP(sub, New_HyperText, roles::SUBSCRIPT)
 
 MARKUPMAP(

accessible/base/RoleMap.h

@@ -1521,4 +1521,15 @@ ROLE(EMPHASIS,
      java::SessionAccessibility::CLASSNAME_VIEW,
      eNameFromSubtreeIfReqRule)
 
+ROLE(STRONG,
+     "strong",
+     nsGkAtoms::strong,
+     ATK_ROLE_STATIC,
+     NSAccessibilityGroupRole,
+     @"AXStrongStyleGroup",
+     ROLE_SYSTEM_GROUPING,
+     IA2_ROLE_TEXT_FRAME,
+     java::SessionAccessibility::CLASSNAME_VIEW,
+     eNameFromSubtreeIfReqRule)
+
 // clang-format on

accessible/interfaces/nsIAccessibleRole.idl

@@ -790,4 +790,8 @@ interface nsIAccessibleRole : nsISupports
    */
   const unsigned long ROLE_EMPHASIS = 135;
 
+  /**
+   * Represents content that is important, serious, or urgent.
+   */
+  const unsigned long ROLE_STRONG = 136;
 };

accessible/tests/mochitest/elm/test_HTMLSpec.html

@@ -1392,7 +1392,12 @@
         role: ROLE_PARAGRAPH,
         children: [
           { role: ROLE_TEXT_LEAF }, // plain text
-          { role: ROLE_TEXT_LEAF }, // HTML:strong text
+          {
+            role: ROLE_STRONG, // HTML:strong text
+            children: [
+              { role: ROLE_TEXT_LEAF, },
+            ],
+          },
         ],
       };
       testElm("strong_container", obj);

accessible/tests/mochitest/role.js

@@ -121,6 +121,7 @@ const ROLE_SLIDER = nsIAccessibleRole.ROLE_SLIDER;
 const ROLE_SPINBUTTON = nsIAccessibleRole.ROLE_SPINBUTTON;
 const ROLE_STATICTEXT = nsIAccessibleRole.ROLE_STATICTEXT;
 const ROLE_STATUSBAR = nsIAccessibleRole.ROLE_STATUSBAR;
+const ROLE_STRONG = nsIAccessibleRole.ROLE_STRONG;
 const ROLE_SUBSCRIPT = nsIAccessibleRole.ROLE_SUBSCRIPT;
 const ROLE_SUGGESTION = nsIAccessibleRole.ROLE_SUGGESTION;
 const ROLE_SUPERSCRIPT = nsIAccessibleRole.ROLE_SUPERSCRIPT;

testing/web-platform/meta/html-aam/roles.html.ini

@@ -1,6 +1,3 @@
 [roles.html]
-  [el-strong]
-    expected: FAIL
-
   [el-time]
     expected: FAIL

testing/web-platform/meta/wai-aria/role/roles.html.ini

@@ -1,8 +1,4 @@
 [roles.html]
-  [role: strong]
-    expected: FAIL
-    bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1732306
-
   [role: time]
     expected: FAIL
     bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1732306