Skip to content

Commit b86b87b

Browse files
committed
Bug 1880428 - [devtools] Make line highlight background color semi-transparent so text selection is visible. r=ochameau,devtools-reviewers.
The background color of the line highlight was opaque, hiding any text selection that could be on that line. Using a color with some transparency makes the selection visible. We take this as an opportunity to fix and refactor the CSS for line highlight. Differential Revision: https://phabricator.services.mozilla.com/D201941
1 parent e5fbaa5 commit b86b87b

File tree

1 file changed

+4
-6
lines changed
  • devtools/client/debugger/src/components/Editor

1 file changed

+4
-6
lines changed

devtools/client/debugger/src/components/Editor/Editor.css

+4-6
Original file line numberDiff line numberDiff line change
@@ -159,15 +159,13 @@ html[dir="rtl"] .editor-mount {
159159
animation-name: fade-highlight-out;
160160
animation-duration: var(--highlight-line-duration);
161161
animation-timing-function: ease-out;
162-
animation-direction: forwards;
162+
animation-fill-mode: forwards;
163163
}
164164

165165
@keyframes fade-highlight-out {
166-
0% {
167-
background-color: var(--theme-contrast-background);
168-
}
169-
30% {
170-
background-color: var(--theme-contrast-background);
166+
0%, 30% {
167+
/* We want to use a color with some transparency so text selection is visible through it */
168+
background-color: var(--theme-contrast-background-alpha);
171169
}
172170
100% {
173171
background-color: transparent;

0 commit comments

Comments
 (0)