Introduce Separate Assay Sidebar

[chrstinalin]

Closes #58

Changes

• Replaces the original sidebar menu with a dedicated Assay menu and added the commands to the palette.
• When add-ons are installed in the root folder, the Assay menu is populated with the add-ons and its (downloaded) versions.
• The user can then 1) add a new addon, 2) open a version in a new window directly, 3) select two versions and launch their diff tool, or 4) select an add-on or version and delete it.
• Surfaces getRootFolderPath() Should be Synchronous #65 (see extension.ts#L29-30)

Original:

New:

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.56757% with 23 lines in your changes missing coverage. Please review.

Project coverage is 93.01%. Comparing base (087359b) to head (6eb7547).
Report is 2 commits behind head on main.

Files	Patch %	Lines
src/controller/directoryController.ts	45.00%	11 Missing ⚠️
src/controller/urlController.ts	58.33%	5 Missing ⚠️
src/controller/sidebarController.ts	88.57%	4 Missing ⚠️
src/controller/addonController.ts	60.00%	2 Missing ⚠️
src/model/sidebarTreeDataProvider.ts	98.43%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main      #64    +/-   ##
========================================
  Coverage   93.00%   93.01%            
========================================
  Files          25       27     +2     
  Lines        2589     2763   +174     
  Branches      162      169     +7     
========================================
+ Hits         2408     2570   +162     
- Misses        177      189    +12     
  Partials        4        4            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrstinalin]

Not sure what's causing this:

Just calling await sidebarController.getTreeView() in extension.ts alone causes the command tests to fail, even when no errors are thrown by it and it resolves.

• This happens even if the entire function is stubbed.
• The variable names aren't used anywhere else.
• The entire activate() function is being run, no lines are missing.

Despite that, the tests passing are just a matter of not calling `await sidebarController.getTreeView()...

EDIT 1: Same issue, just with

const rootFolderPath = await directoryController.getRootFolderPath();. The function resolves, but tests fail just by calling it (regardless of whether its a stub).

EDIT 2: It's specifically the RootView.selectRootFolder() call inside getRootFolderPath().

EDIT 3: If not awaited,directoryController.getRootFolderPath()will pass.

EDIT 4: I have a feeling it has something to do with a timing issue with showOpenDialog. Even when stubbed in, for example, the RootView or showRootFolderPath tests, the dialog will always open (unlike QuickPick and other VS Code dialogs). Maybe activate is run through as indicated by the test results, but command registrations do not finish in time?

EDIT 5: I've removed the tests as there's no clear way to fix it.

[willdurand]

Please address the comments before landing this PR.

[willdurand]

You can probably make that simpler:

Suggested change

	const thenable = vscode.workspace.fs.delete(item.uri, { recursive: true });
	const promise = Promise.resolve(thenable).catch(() => failedUris.push(item.uri));
	promises.push(promise);
	const promise = vscode.workspace.fs.delete(item.uri, { recursive: true }).catch(() => failedUris.push(item.uri));
	promises.push(promise);

[chrstinalin]

Typescript gets mad since 'catch' doesn't exist on type 'Thenable'. As far as I can tell Thenables can do catches, but by using the onRejected parameter of .then() -- and this felt more legible in comparison.